Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(middleware/session): re-write session middleware with handler #3016

Merged
merged 93 commits into from
Oct 25, 2024
Merged

feat!(middleware/session): re-write session middleware with handler #3016

merged 93 commits into from
Oct 25, 2024

Commits on May 28, 2024

  1. feat!(middleware/session): re-write session middleware with handler

    @sixcolors
    sixcolors committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6e76847 View commit details
    Browse the repository at this point in the history

  2. test(middleware/session): refactor to IdleTimeout

    @sixcolors
    sixcolors committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ac9a028 View commit details
    Browse the repository at this point in the history

  3. fix: lint errors

    @sixcolors
    sixcolors committed May 28, 2024
    Configuration menu
    Copy the full SHA
    81f6789 View commit details
    Browse the repository at this point in the history

  4. test: Save session after setting or deleting raw data in CSRF middleware

    @sixcolors
    sixcolors committed May 28, 2024
    Configuration menu
    Copy the full SHA
    28790cb View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Update middleware/session/middleware.go 

    Co-authored-by: Renan Bastos <[email protected]>
    @sixcolors @renanbastos93
    sixcolors and renanbastos93 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    7ffae3d View commit details
    Browse the repository at this point in the history

  2. fix: mutex and globals order

    @sixcolors
    sixcolors committed May 30, 2024
    Configuration menu
    Copy the full SHA
    68f2739 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. feat: Re-Add read lock to session Get method

    @sixcolors
    sixcolors committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    92e6877 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. feat: Migrate New() to return middleware

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    239db00 View commit details
    Browse the repository at this point in the history

  2. chore: Refactor session middleware to improve session handling

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    0b93c5c View commit details
    Browse the repository at this point in the history

  3. chore: Private get on store

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    7cb4a6e View commit details
    Browse the repository at this point in the history

  4. chore: Update session middleware to use saveSession instead of save

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    b4c8ea8 View commit details
    Browse the repository at this point in the history

  5. chore: Update session middleware to use getSession instead of get

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    aafee92 View commit details
    Browse the repository at this point in the history

  6. chore: Remove unused error handler in session middleware config

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    cd91db4 View commit details
    Browse the repository at this point in the history

  7. chore: Update session middleware to use NewWithStore in CSRF tests

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    c3b303f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors authored Jun 15, 2024
    Configuration menu
    Copy the full SHA
    75cffca View commit details
    Browse the repository at this point in the history

  9. test: add test

    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    2731428 View commit details
    Browse the repository at this point in the history

  10. Merge branch '2741-session-changes' of https://github.com/sixcolors/f… 

    …iber into pr/3016
    @sixcolors
    sixcolors committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    4f04291 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. fix: destroyed session and GHSA-98j2-3j3p-fw2v

    @sixcolors
    sixcolors committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ee193dc View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge remote-tracking branch 'origin/main' into 2741-session-changes

    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    01571cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5f032d4 View commit details
    Browse the repository at this point in the history

  3. chore: Refactor session_test.go to use newStore() instead of New()

    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1a5a3d7 View commit details
    Browse the repository at this point in the history

  4. feat: Improve session middleware test coverage and error handling 

    This commit improves the session middleware test coverage by adding assertions for the presence of the Set-Cookie header and the token value. It also enhances error handling by checking for the expected number of parts in the Set-Cookie header.
    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    52e41a4 View commit details
    Browse the repository at this point in the history

  5. chore: fix lint issues

    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ed95d83 View commit details
    Browse the repository at this point in the history

  6. chore: Fix session middleware locking issue and improve error handling

    @sixcolors
    sixcolors committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c6e1c34 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. test: improve middleware test coverage and error handling

    @sixcolors
    sixcolors committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    8a5663a View commit details
    Browse the repository at this point in the history

  2. test: Add idle timeout test case to session middleware test

    @sixcolors
    sixcolors committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    46845e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. feat: add GetSession(id string) (*Session, error)

    @sixcolors
    sixcolors committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    ba0e491 View commit details
    Browse the repository at this point in the history

  2. chore: lint

    @sixcolors
    sixcolors committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    d08b686 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'main' into pr/3016

    @sixcolors
    sixcolors committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8df7c81 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'main' into pr/3016

    @sixcolors
    sixcolors committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    508cf24 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'main' into pr/3016

    @sixcolors
    sixcolors committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6ee953b View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Merge branch 'main' into pr/3016

    @sixcolors
    sixcolors committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    355b8f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2f3f724 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. docs: Update session middleware docs

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    c08ddc1 View commit details
    Browse the repository at this point in the history

  2. docs: Security Note to examples

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    56f6ce0 View commit details
    Browse the repository at this point in the history

  3. docs: Add recommendation for CSRF protection in session middleware

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9e406f4 View commit details
    Browse the repository at this point in the history

  4. chore: markdown lint

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    12b219a View commit details
    Browse the repository at this point in the history

  5. docs: Update session middleware docs

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6812fc4 View commit details
    Browse the repository at this point in the history

  6. docs: makrdown lint

    @sixcolors
    sixcolors committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    28aad65 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d4e607e View commit details
    Browse the repository at this point in the history

  2. test(middleware/session): Add unit tests for session config.go

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    14c7a6c View commit details
    Browse the repository at this point in the history

  3. test(middleware/session): Add unit tests for store.go

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a865ba5 View commit details
    Browse the repository at this point in the history

  4. test(middleware/session): Add data.go unit tests

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eaedc6d View commit details
    Browse the repository at this point in the history

  5. refactor(middleware/session): session tests and add session release test 

    - Refactor session tests to improve readability and maintainability.
- Add a new test case to ensure proper session release functionality.
- Update session.md
    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d2cf5b8 View commit details
    Browse the repository at this point in the history

  6. refactor: session data locking in middleware/session/data.go

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b479895 View commit details
    Browse the repository at this point in the history

  7. refactor(middleware/session): Add unit test for session middleware store

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    afab580 View commit details
    Browse the repository at this point in the history

  8. test: fix session_test.go and store_test.go unit tests

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6c0bf25 View commit details
    Browse the repository at this point in the history

  9. refactor(docs): Update session.md with v3 changes to Expiration

    @sixcolors
    sixcolors committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ad337f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. refactor(middleware/session): Improve data pool handling and locking

    @sixcolors
    sixcolors committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    280d539 View commit details
    Browse the repository at this point in the history

  2. chore(middleware/session): TODO for Expiration field in session config

    @sixcolors
    sixcolors committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    40da2c0 View commit details
    Browse the repository at this point in the history

  3. refactor(middleware/session): Improve session data pool handling and … 

    …locking
    @sixcolors
    sixcolors committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3ad4bc9 View commit details
    Browse the repository at this point in the history

  4. refactor(middleware/session): Improve session data pool handling and … 

    …locking
    @sixcolors
    sixcolors committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ffac824 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. test(middleware/csrf): add session middleware coverage

    @sixcolors
    sixcolors committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9f8c2d7 View commit details
    Browse the repository at this point in the history

  2. chroe(middleware/session): TODO for unregistered session middleware

    @sixcolors
    sixcolors committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ecac9ce View commit details
    Browse the repository at this point in the history

  3. refactor(middleware/session): Update session middleware for v3 changes

    @sixcolors
    sixcolors committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e272082 View commit details
    Browse the repository at this point in the history

  4. refactor(middleware/session): Update session middleware for v3 changes

    @sixcolors
    sixcolors committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b262a08 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into pr/3016

    @sixcolors
    sixcolors committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    937a9b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. refactor(middleware/session): Update session middleware idle timeout 

    - Update the default idle timeout for session middleware from 24 hours to 30 minutes.
- Add a note in the session middleware documentation about the importance of the middleware order.
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9ec2b30 View commit details
    Browse the repository at this point in the history

  2. docws(middleware/session): Add note about IdleTimeout requiring save … 

    …using legacy approach
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    684dc8a View commit details
    Browse the repository at this point in the history

  3. refactor(middleware/session): Update session middleware idle timeout 

    Update the idle timeout for the session middleware to 30 minutes. This ensures that the session expires after a period of inactivity. The previous value was 24 hours, which is too long for most use cases. This change improves the security and efficiency of the session management.
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    05d30a4 View commit details
    Browse the repository at this point in the history

  4. docs(middleware/session): Update session middleware idle timeout and … 

    …configuration
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ec5a698 View commit details
    Browse the repository at this point in the history

  5. test(middleware/session): Fix tests for updated panics

    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    13a1eb4 View commit details
    Browse the repository at this point in the history

  6. refactor(middleware/session): Update session middleware initializatio… 

    …n and saving
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9d3b032 View commit details
    Browse the repository at this point in the history

  7. refactor(middleware/session): Remove unnecessary comment about negati… 

    …ve IdleTimeout value
    @sixcolors
    sixcolors committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9762767 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. refactor(middleware/session): Update session middleware make NewStore… 

    … public
    @sixcolors
    sixcolors committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e59905f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7765ee5 View commit details
    Browse the repository at this point in the history

  3. refactor(middleware/session): Update session middleware Set, Get, and… 

    … Delete methods

Refactor the Set, Get, and Delete methods in the session middleware to use more descriptive parameter names. Instead of using "middlewareContextKey", the methods now use "key" to represent the key of the session value. This improves the readability and clarity of the code.
    @sixcolors
    sixcolors committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8716c95 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'main' into 2741-session-changes

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0e302e9 View commit details
    Browse the repository at this point in the history

  2. feat(middleware/session): AbsoluteTimeout and key any

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    951691d View commit details
    Browse the repository at this point in the history

  3. fix(middleware/session): locking issues and lint errors

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3ac9b68 View commit details
    Browse the repository at this point in the history

  4. chore(middleware/session): Regenerate code in data_msgp.go

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bc95c6a View commit details
    Browse the repository at this point in the history

  5. refactor(middleware/session): rename GetSessionByID to GetByID 

    This commit also includes changes to the session_test.go and store_test.go files to add test cases for the new GetByID method.
    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6bba849 View commit details
    Browse the repository at this point in the history

  6. docs(middleware/session): AbsoluteTimeout

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    281c0e1 View commit details
    Browse the repository at this point in the history

  7. refactor(middleware/csrf): Rename Expiration to IdleTimeout

    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3d88ece View commit details
    Browse the repository at this point in the history

  8. docs(whats-new): CSRF Rename Expiration to IdleTimeout and remove Ses… 

    …sionKey field
    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3ddfeae View commit details
    Browse the repository at this point in the history

  9. refactor(middleware/session): Rename expirationKeyType to absExpirati… 

    …onKeyType and update related functions
    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c3d3f0c View commit details
    Browse the repository at this point in the history

  10. refactor(middleware/session): rename Test_Session_Save_Absolute to Te… 

    …st_Session_Save_AbsoluteTimeout
    @sixcolors
    sixcolors committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0e9a73e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. chore(middleware/session): update as per PR comments

    @sixcolors
    sixcolors committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a467236 View commit details
    Browse the repository at this point in the history

  2. docs(middlware/session): fix indent lint

    @sixcolors
    sixcolors committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6f35ff8 View commit details
    Browse the repository at this point in the history

  3. fix(middleware/session): Address EfeCtn Comments

    @sixcolors
    sixcolors committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f3c4e8e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. refactor(middleware/session): Move bytesBuffer to it's own pool

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e41ee74 View commit details
    Browse the repository at this point in the history

  2. test(middleware/session): add decodeSessionData error coverage

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    07092c8 View commit details
    Browse the repository at this point in the history

  3. refactor(middleware/session): Update absolute timeout handling 

    - Update absolute timeout handling in getSession function
- Set absolute expiration time in getSession function
- Delete expired session in GetByID function
    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    84adbe1 View commit details
    Browse the repository at this point in the history

  4. refactor(session/middleware): fix *Session nil ctx when using Store.G… 

    …etByID
    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f6440e2 View commit details
    Browse the repository at this point in the history

  5. refactor(middleware/session): Remove unnecessary line in session_test.go

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eac16b6 View commit details
    Browse the repository at this point in the history

  6. fix(middleware/session): *Session lifecycle issues

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    7068a0e View commit details
    Browse the repository at this point in the history

  7. docs(middleware/session): Update GetByID method documentation

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    87a6cb9 View commit details
    Browse the repository at this point in the history

  8. docs(middleware/session): Update GetByID method documentation

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e5e5fd8 View commit details
    Browse the repository at this point in the history

  9. docs(middleware/session): markdown lint

    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    00b9e07 View commit details
    Browse the repository at this point in the history

  10. refactor(middleware/session): Simplify error handling in DefaultError… 

    …Handler
    @sixcolors
    sixcolors committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    23e823b View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. fix( middleware/session/config.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @sixcolors @coderabbitai
    sixcolors and coderabbitai[bot] authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ba38786 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'main' into 2741-session-changes

    @gaby
    gaby authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f77fa8f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. add ctx releases for the test cases

    @ReneWerner87
    ReneWerner87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b54c954 View commit details
    Browse the repository at this point in the history