internal/relui/sign: add binary artifact signing modes

For golang/vscode-go#3186 Change-Id: I684e222cc018b18ad0c173522dfd70cb3b34e0ca Reviewed-on: https://go-review.googlesource.com/c/build/+/571575 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
golang · Apr 5, 2024 · 914cd3b · 914cd3b
1 parent a8b77d5
commit 914cd3b
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 65 deletions.
diff --git a/internal/relui/protos/relui.pb.go b/internal/relui/protos/relui.pb.go
diff --git a/internal/relui/protos/relui.proto b/internal/relui/protos/relui.proto
@@ -49,6 +49,11 @@ message SignArtifactRequest {
 
     BUILD_TYPE_MACOS_CONSTRUCT_INSTALLER_ONLY = 4;
     BUILD_TYPE_WINDOWS_CONSTRUCT_INSTALLER_ONLY = 5;
+
+    // Sign individual binary application artifacts.
+    // The signing server expects zipped application bundles and signs the files in them.
+    BUILD_TYPE_MACOS_BINARY = 6;
+    BUILD_TYPE_WINDOWS_BINARY = 7;
   }
   BuildType build_type = 1;
 

diff --git a/internal/relui/protos/relui_grpc.pb.go b/internal/relui/protos/relui_grpc.pb.go
diff --git a/internal/relui/sign/sign.go b/internal/relui/sign/sign.go
@@ -66,6 +66,9 @@ const (
 
 	BuildMacOSConstructInstallerOnly
 	BuildWindowsConstructInstallerOnly
+
+	BuildMacOSBinary
+	BuildWindowsBinary
 )
 
 // proto is the corresponding protobuf definition for the signing request build type.
@@ -81,6 +84,10 @@ func (bt BuildType) proto() protos.SignArtifactRequest_BuildType {
 		return protos.SignArtifactRequest_BUILD_TYPE_MACOS_CONSTRUCT_INSTALLER_ONLY
 	case BuildWindowsConstructInstallerOnly:
 		return protos.SignArtifactRequest_BUILD_TYPE_WINDOWS_CONSTRUCT_INSTALLER_ONLY
+	case BuildMacOSBinary:
+		return protos.SignArtifactRequest_BUILD_TYPE_MACOS_BINARY
+	case BuildWindowsBinary:
+		return protos.SignArtifactRequest_BUILD_TYPE_WINDOWS_BINARY
 	default:
 		return protos.SignArtifactRequest_BUILD_TYPE_UNSPECIFIED
 	}
@@ -98,6 +105,10 @@ func (bt BuildType) String() string {
 		return "macOS (construct installer only)"
 	case BuildWindowsConstructInstallerOnly:
 		return "Windows (construct installer only)"
+	case BuildMacOSBinary:
+		return "macOS (binary)"
+	case BuildWindowsBinary:
+		return "Windows (binary)"
 	default:
 		return "unspecified"
 	}