sha3: add SIMD implementation with ARMv8.2 features #182

howjmay · 2021-05-11T16:36:35Z

sha3: add SIMD implementation with ARMv8.2 features

On ARMv8 four SIMD instructions, EOR3, RAX1, XAR, BCAX are added
to accelerate sha3 operations. Here the SIMD version of sha3
on ARMv8 is added.

Compare to the pure golang implementation (the implementation in
keccakf.go) on Apple M1 chip, the time difference is listed in the following

benchmark old ns/op new ns/op delta
BenchmarkPermutationFunction-8 227.0 ns/op 153.6 ns/op -32.33%
BenchmarkSha3_512_MTU-8 4954 ns/op 3296 ns/op -33.47%
BenchmarkSha3_384_MTU-8 3586 ns/op 2441 ns/op -31.93%
BenchmarkSha3_256_MTU-8 2909 ns/op 1982 ns/op -31.87%
BenchmarkSha3_224_MTU-8 2779 ns/op 1905 ns/op -31.45%
BenchmarkShake128_MTU-8 2326 ns/op 1588 ns/op -31.73%
BenchmarkShake256_MTU-8 2485 ns/op 1670 ns/op -32.80%
BenchmarkShake256_16x-8 37052 ns/op 26715 ns/op -27.90%
BenchmarkShake256_1MiB-8 1911863 ns/op 1293014 ns/op -32.37%
BenchmarkSha3_512_1MiB-8 3496335 ns/op 2317853 ns/op -33.71%

benchmark old MB/s new MB/s speedup
BenchmarkPermutationFunction-8 881.22 MB/s 1302.48 MB/s 1.48x
BenchmarkSha3_512_MTU-8 272.50 MB/s 409.64 MB/s 1.50x
BenchmarkSha3_384_MTU-8 376.47 MB/s 553.06 MB/s 1.47x
BenchmarkSha3_256_MTU-8 464.11 MB/s 681.27 MB/s 1.47x
BenchmarkSha3_224_MTU-8 485.75 MB/s 708.83 MB/s 1.46x
BenchmarkShake128_MTU-8 580.32 MB/s 849.97 MB/s 1.46x
BenchmarkShake256_MTU-8 543.34 MB/s 808.53 MB/s 1.49x
BenchmarkShake256_16x-8 442.19 MB/s 613.29 MB/s 1.39x
BenchmarkShake256_1MiB-8 548.46 MB/s 810.95 MB/s 1.48x
BenchmarkSha3_512_1MiB-8 299.91 MB/s 452.39 MB/s 1.51x

Result from 'benchstat'
name old time/op new time/op delta
PermutationFunction-8 306ns ± 2% 153ns ± 0% -49.98% (p=0.000 n=10+10)

name old speed new speed delta
PermutationFunction-8 654MB/s ± 2% 1308MB/s ± 0% +99.91% (p=0.000 n=10+10)

name old alloc/op new alloc/op delta
PermutationFunction-8 0.00B 0.00B ~ (all equal)

name old allocs/op new allocs/op delta
PermutationFunction-8 0.00 0.00 ~ (all equal)

Change-Id: I7e24f5c44ef96e1301190db6a21add407ce13af0
GitHub-Last-Rev: acc175a
GitHub-Pull-Request: #182

gopherbot · 2021-05-11T16:38:50Z

This PR (HEAD: e1651cc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-11T16:40:55Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-11T16:50:00Z

This PR (HEAD: 417caef) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-11T16:52:18Z

This PR (HEAD: f4b87ef) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T03:39:27Z

This PR (HEAD: e8fb822) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T03:41:32Z

This PR (HEAD: 4383406) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T08:43:03Z

This PR (HEAD: 3b1cf3e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T09:03:21Z

This PR (HEAD: f993927) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T14:32:36Z

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-12T15:02:51Z

This PR (HEAD: a223041) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T15:22:51Z

This PR (HEAD: 7a572dc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T15:25:07Z

This PR (HEAD: 7a6265e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T16:13:55Z

This PR (HEAD: 080b167) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-12T16:21:34Z

Message from Hau Yang:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-12T16:45:21Z

This PR (HEAD: 48dd072) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-20T12:58:20Z

Message from Meng Zhuo:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-20T15:14:18Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:24Z

Message from Hau Yang:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:25Z

Message from Hau Yang:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:26Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:27Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:28Z

Message from Meng Zhuo:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:05:29Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

On ARMv8 four SIMD instructions, EOR3, RAX1, XAR, BCAX are added to accelerate sha3 operations. Here the SIMD version of sha3 on ARMv8 is added. Compare to the pure golang implementation (the implementation in keccakf.go), the time difference is listed in the following benchmark old ns/op new ns/op delta BenchmarkPermutationFunction-8 227.0 ns/op 153.6 ns/op -32.33% BenchmarkSha3_512_MTU-8 4954 ns/op 3296 ns/op -33.47% BenchmarkSha3_384_MTU-8 3586 ns/op 2441 ns/op -31.93% BenchmarkSha3_256_MTU-8 2909 ns/op 1982 ns/op -31.87% BenchmarkSha3_224_MTU-8 2779 ns/op 1905 ns/op -31.45% BenchmarkShake128_MTU-8 2326 ns/op 1588 ns/op -31.73% BenchmarkShake256_MTU-8 2485 ns/op 1670 ns/op -32.80% BenchmarkShake256_16x-8 37052 ns/op 26715 ns/op -27.90% BenchmarkShake256_1MiB-8 1911863 ns/op 1293014 ns/op -32.37% BenchmarkSha3_512_1MiB-8 3496335 ns/op 2317853 ns/op -33.71% benchmark old MB/s new MB/s speedup BenchmarkPermutationFunction-8 881.22 MB/s 1302.48 MB/s 1.48x BenchmarkSha3_512_MTU-8 272.50 MB/s 409.64 MB/s 1.50x BenchmarkSha3_384_MTU-8 376.47 MB/s 553.06 MB/s 1.47x BenchmarkSha3_256_MTU-8 464.11 MB/s 681.27 MB/s 1.47x BenchmarkSha3_224_MTU-8 485.75 MB/s 708.83 MB/s 1.46x BenchmarkShake128_MTU-8 580.32 MB/s 849.97 MB/s 1.46x BenchmarkShake256_MTU-8 543.34 MB/s 808.53 MB/s 1.49x BenchmarkShake256_16x-8 442.19 MB/s 613.29 MB/s 1.39x BenchmarkShake256_1MiB-8 548.46 MB/s 810.95 MB/s 1.48x BenchmarkSha3_512_1MiB-8 299.91 MB/s 452.39 MB/s 1.51x

gopherbot · 2022-09-04T09:03:18Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T09:03:19Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T09:03:19Z

Message from Ian Lance Taylor:

Patch Set 20:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T09:03:23Z

This PR (HEAD: acc175a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/318869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-04T09:07:26Z

Message from Hau Yang:

Patch Set 21:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T09:42:04Z

Message from Hau Yang:

Patch Set 22:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:46Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:47Z

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:48Z

Message from Hau Yang:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:49Z

Message from Hau Yang:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:50Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:51Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:52Z

Message from M Zhuo:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:53Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:54Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:55Z

Message from Hau Yang:

Patch Set 20:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:56Z

Message from Ian Lance Taylor:

Patch Set 20:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:58Z

Message from Hau Yang:

Patch Set 21:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:24:58Z

Message from Hau Yang:

Patch Set 22:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-27T13:19:15Z

Message from Hau Yang:

Patch Set 22:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/318869.
After addressing review feedback, remember to publish your drafts!

google-cla bot added the cla: yes label May 11, 2021

howjmay force-pushed the sha3-armv8-acceleration branch from e1651cc to 417caef Compare May 11, 2021 16:47

howjmay force-pushed the sha3-armv8-acceleration branch from 417caef to f4b87ef Compare May 11, 2021 16:51

howjmay mentioned this pull request May 11, 2021

x/crypto/sha3: add SHA3 assembly implementation for ARMv7 golang/go#28148

Open

howjmay force-pushed the sha3-armv8-acceleration branch from f4b87ef to e8fb822 Compare May 12, 2021 03:38

howjmay force-pushed the sha3-armv8-acceleration branch from e8fb822 to 4383406 Compare May 12, 2021 03:41

howjmay force-pushed the sha3-armv8-acceleration branch from 4383406 to 3b1cf3e Compare May 12, 2021 08:42

howjmay force-pushed the sha3-armv8-acceleration branch from 3b1cf3e to f993927 Compare May 12, 2021 09:01

howjmay force-pushed the sha3-armv8-acceleration branch from f993927 to a223041 Compare May 12, 2021 15:02

howjmay force-pushed the sha3-armv8-acceleration branch 2 times, most recently from 6a87407 to 7a572dc Compare May 12, 2021 15:22

howjmay force-pushed the sha3-armv8-acceleration branch from 7a572dc to 7a6265e Compare May 12, 2021 15:23

howjmay force-pushed the sha3-armv8-acceleration branch from 7a6265e to 080b167 Compare May 12, 2021 16:10

howjmay force-pushed the sha3-armv8-acceleration branch from 080b167 to 48dd072 Compare May 12, 2021 16:43

howjmay force-pushed the sha3-armv8-acceleration branch from 48dd072 to 02cef39 Compare May 12, 2021 16:46

howjmay force-pushed the sha3-armv8-acceleration branch from d9aa0f1 to acc175a Compare September 4, 2022 09:02

sha3: add SIMD implementation with ARMv8.2 features #182

Are you sure you want to change the base?

sha3: add SIMD implementation with ARMv8.2 features #182

Conversation

howjmay commented May 11, 2021 • edited Loading

gopherbot commented May 11, 2021

gopherbot commented May 11, 2021

gopherbot commented May 11, 2021

gopherbot commented May 11, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented May 12, 2021

gopherbot commented Sep 20, 2021

gopherbot commented Sep 20, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Sep 4, 2022

gopherbot commented Sep 4, 2022

gopherbot commented Sep 4, 2022

gopherbot commented Sep 4, 2022

gopherbot commented Sep 4, 2022

gopherbot commented Sep 4, 2022

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Sep 25, 2023

gopherbot commented Oct 27, 2023

howjmay commented May 11, 2021 •

edited

Loading