Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: implement partial success in server #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterverraedt
Copy link
Contributor

Add support for sending back partial success to the client while
handling authentication in the server. This is implemented by a special
error that can be returned by any of the authentication methods, which
contains the authentication methods to offer next. This way a server
can be implemented that e.g. only accepts public keys for the initial
authentication, and only after partial success presents a keyboard
interactive authentication method.

Signed-off-by: Peter Verraedt [email protected]

Add support for sending back partial success to the client while
handling authentication in the server. This is implemented by a special
error that can be returned by any of the authentication methods, which
contains the authentication methods to offer next. This way a server
can be implemented that e.g. only accepts public keys for the initial
authentication, and only after partial success presents a keyboard
interactive authentication method.

Signed-off-by: Peter Verraedt <[email protected]>
@gopherbot
Copy link
Contributor

This PR (HEAD: dccdcf8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/399075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/399075.
After addressing review feedback, remember to publish your drafts!

@drakkan
Copy link
Member

drakkan commented Apr 9, 2022

Hi,

I sent a similar patch here. I think we need to wrote a proposal for the API change before a patch can be accepted

thorstenc added a commit to couchdrop/go-crypto that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants