-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptobyte: add support for UTCTIME values #34
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
This PR (HEAD: 1d8c54a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/crypto/+/98135 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
This PR (HEAD: 6cf5e90) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/crypto/+/98135 to see it. Tip: You can toggle comments from me using the |
Message from Andrew Bonventre: Patch Set 2: Run-TryBot+1 Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c26950f Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: -Run-TryBot -Code-Review Ping to original author of change. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: Also, does this require a crypto proposal at all? Will let Filippo weigh in. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c26950f Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: Run-TryBot+1 Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c26950f Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: -Run-TryBot -Code-Review Ping to original author of change. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: Also, does this require a crypto proposal at all? Will let Filippo weigh in. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: Run-TryBot+1 Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gopher Robot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c26950f Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: -Run-TryBot -Code-Review Ping to original author of change. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Message from Andrew Bonventre: Patch Set 2: Also, does this require a crypto proposal at all? Will let Filippo weigh in. Please don’t reply on this GitHub thread. Visit golang.org/cl/98135. |
Hi, I have added support for UTC time, and a helper method that decodes time values regardless of the time tag used.