ssh: disable wantReply in some requests to comply with OpenSSH

[ilyaluk-old]

The existing implementation does not comply with OpenSSH, where
some requests is sent without wantReply flag.

[email protected]:
https://github.com/openssh/openssh-portable/blob/V_8_0_P1/ssh.c#L1815
(wantconfirm=0)

env:
https://github.com/openssh/openssh-portable/blob/V_8_0_P1/clientloop.c#L2299

cancel-tcpip-forward:
https://github.com/openssh/openssh-portable/blob/V_8_0_P1/channels.c#L565

[email protected]:
https://github.com/openssh/openssh-portable/blob/V_8_0_P1/channels.c#L4017

[gopherbot]

This PR (HEAD: c8000f4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/190777 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 2: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 3: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: f54c30f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/190777 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 6: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 9:

No changes to tests?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 9:

Patch Set 9:

No changes to tests?

Apparently, it's not tested in code, because sshd is used to test client, as far as I understand. OpenSSH server seems to be okay with any implementation (it checks wantReply in any case).

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 9:

Let me put it another way: what's broken?

Add a test that's broken but is fixed with this change.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 2: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 3: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 6: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 9:

No changes to tests?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ilya Lukyanov:

Patch Set 9:

Patch Set 9:

No changes to tests?

Apparently, it's not tested in code, because sshd is used to test client, as far as I understand. OpenSSH server seems to be okay with any implementation (it checks wantReply in any case).

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 9:

Let me put it another way: what's broken?

Add a test that's broken but is fixed with this change.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/190777.
After addressing review feedback, remember to publish your drafts!