bcrypt: add easy bcrypt example #99

elgohr · 2019-09-03T17:36:16Z

No description provided.

googlebot · 2019-09-03T17:36:19Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

elgohr · 2019-09-03T17:37:24Z

@googlebot I signed it!

googlebot · 2019-09-03T17:37:27Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gopherbot · 2019-09-03T17:38:03Z

This PR (HEAD: 9b37a44) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-03T17:39:01Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T01:14:41Z

Message from Akhil Indurti:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T06:03:53Z

Message from Lars Gohr:

Patch Set 1:

I'll correct the commit message.
The second comment doesn't match the documentation (https://godoc.org/golang.org/x/crypto/bcrypt#CompareHashAndPassword).
At my point of view I would like to go with the error.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T06:05:50Z

Message from Akhil Indurti:

Patch Set 1:

Patch Set 1:

I'll correct the commit message.
The second comment doesn't match the documentation (https://godoc.org/golang.org/x/crypto/bcrypt#CompareHashAndPassword).
At my point of view I would like to go with the error.

I misread! Thanks for pointing that out. :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T06:05:51Z

Message from Lars Gohr:

Patch Set 1:

Patch Set 1:

I'll correct the commit message.
The second comment doesn't match the documentation (https://godoc.org/golang.org/x/crypto/bcrypt#CompareHashAndPassword).
At my point of view I would like to go with the error.

Sorry, didn't read correctly. Will also have a look at the second.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T06:08:00Z

Message from Akhil Indurti:

Patch Set 1:

Patch Set 1:

Patch Set 1:

I'll correct the commit message.
The second comment doesn't match the documentation (https://godoc.org/golang.org/x/crypto/bcrypt#CompareHashAndPassword).
At my point of view I would like to go with the error.

I misread! Thanks for pointing that out. :)

Confused myself there.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-08T12:27:33Z

This PR (HEAD: 9bf4791) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

flowHater · 2019-09-09T11:34:47Z

bcrypt/bcrypt_test.go

+
+func ExampleBcrypting() {
+	password := []byte("mypassword")
+	securedPassword, err := GenerateFromPassword(password, DefaultCost)


Maybe you can rename it hashedPassword, like the first param of CompareHashAndPassword

It's salted and hashed. As saltedHashedPassword was a little to long for me, I called it secured.
Does that make sense?

Ok. But securedPassword comes from nowhere. But it's clear to me.
I try to improve.
But you're right. 👍

gopherbot · 2019-09-16T09:50:10Z

Message from Lars Gohr:

Patch Set 2:

Should be fixed now

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-29T22:25:58Z

Message from Akhil Indurti:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T22:13:21Z

Message from Akhil Indurti:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T22:13:21Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e3cd2cc9

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T22:18:15Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

elgohr · 2019-11-01T06:52:05Z

So what's missing for this getting merged?

gopherbot · 2019-11-01T13:56:33Z

Message from Ian Lance Taylor:

Patch Set 2:

Ping Filippo.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-01T18:25:42Z

Message from Lars Gohr:

Patch Set 2:

Patch Set 2:

Ping Filippo.

Already did that on the 16th of October via Twitter...

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

elgohr · 2019-12-26T21:06:53Z

Ping

elgohr · 2020-03-05T20:17:31Z

Ping

gopherbot · 2020-03-08T23:16:38Z

Message from Dave Cheney:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-09T08:13:02Z

This PR (HEAD: 155868f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-09T08:14:28Z

This PR (HEAD: 4cac054) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-19T21:44:14Z

Message from Filippo Valsorda:

Patch Set 6:

(5 comments)

Thank you! A few nits.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-19T22:20:19Z

Message from Akhil Indurti:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-19T22:42:36Z

Message from Filippo Valsorda:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-20T11:49:09Z

This PR (HEAD: bd8e858) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

…CompareHashAndPassword more clear

gopherbot · 2020-03-20T11:52:21Z

This PR (HEAD: f6acff4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/193079 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

elgohr · 2020-04-23T06:44:26Z

Ping

gopherbot · 2020-05-07T21:28:10Z

Message from Akhil Indurti:

Patch Set 9: Code-Review+1

Looks good to me. Even though we're in the freeze,
this is an example, so I think it should be okay.

Ping Filippo.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

elgohr · 2020-09-17T16:54:42Z

Ping

gopherbot · 2020-09-17T18:45:33Z

Message from Ian Lance Taylor:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:40:37Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:40:38Z

Message from Go Bot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e3cd2cc9

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:40:38Z

Message from Go Bot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/193079.
After addressing review feedback, remember to publish your drafts!

elgohr · 2022-08-01T16:56:57Z

Ping...

googlebot added the cla: no label Sep 3, 2019

googlebot added cla: yes and removed cla: no labels Sep 3, 2019

bcrypt: add easy example

9bf4791

elgohr force-pushed the master branch from 9b37a44 to 9bf4791 Compare September 8, 2019 12:27

flowHater approved these changes Sep 9, 2019

View reviewed changes

flowHater reviewed Sep 9, 2019

View reviewed changes

flowHater approved these changes Sep 18, 2019

View reviewed changes

elgohr changed the title ~~Add easy bcrypt example~~ golang.org/x/crypto/bcrypt: Add easy bcrypt example Mar 7, 2020

elgohr changed the title ~~golang.org/x/crypto/bcrypt: Add easy bcrypt example~~ golang.org/x/crypto/bcrypt: add easy bcrypt example Mar 7, 2020

bcrypt: Externalize example to separate package

4cac054

elgohr force-pushed the master branch from 155868f to 4cac054 Compare March 9, 2020 08:13

elgohr changed the title ~~golang.org/x/crypto/bcrypt: add easy bcrypt example~~ bcrypt: add easy bcrypt example Mar 20, 2020

bcrypt: Add copyright header. Refactor storedPassword. Make usage of …

f6acff4

…CompareHashAndPassword more clear

elgohr force-pushed the master branch from bd8e858 to f6acff4 Compare March 20, 2020 11:52

flowHater approved these changes Oct 2, 2020

View reviewed changes

google-cla bot added cla: no and removed cla: yes labels Mar 3, 2023

bcrypt: add easy bcrypt example #99

Are you sure you want to change the base?

bcrypt: add easy bcrypt example #99

Conversation

elgohr commented Sep 3, 2019

googlebot commented Sep 3, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

elgohr commented Sep 3, 2019

googlebot commented Sep 3, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 8, 2019

gopherbot commented Sep 8, 2019

gopherbot commented Sep 8, 2019

gopherbot commented Sep 8, 2019

gopherbot commented Sep 8, 2019

gopherbot commented Sep 8, 2019

flowHater Sep 9, 2019

Choose a reason for hiding this comment

elgohr Sep 9, 2019

Choose a reason for hiding this comment

elgohr Sep 12, 2019

Choose a reason for hiding this comment

flowHater Sep 18, 2019

Choose a reason for hiding this comment

gopherbot commented Sep 16, 2019

gopherbot commented Sep 29, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

elgohr commented Nov 1, 2019

gopherbot commented Nov 1, 2019

gopherbot commented Nov 1, 2019

elgohr commented Dec 26, 2019

elgohr commented Mar 5, 2020

gopherbot commented Mar 8, 2020

gopherbot commented Mar 9, 2020

gopherbot commented Mar 9, 2020

gopherbot commented Mar 19, 2020

gopherbot commented Mar 19, 2020

gopherbot commented Mar 19, 2020

gopherbot commented Mar 20, 2020

gopherbot commented Mar 20, 2020

elgohr commented Apr 23, 2020

gopherbot commented May 7, 2020

elgohr commented Sep 17, 2020

gopherbot commented Sep 17, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

elgohr commented Aug 1, 2022