shiny/text: drop panic when GlyphAdvance returns !ok

As the commit message of CL 474376 notes, the "TODO: is falling back on the U+FFFD glyph the responsibility of the Drawer or the Face?" was resolved. There's no need to panic anymore. Updates golang/go#58252. Change-Id: Ic4bcc3dfb8a463e7abcfccdbcf826644327f1aec Reviewed-on: https://go-review.googlesource.com/c/exp/+/552616 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <[email protected]> Reviewed-by: Nigel Tao <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
golang · Dec 26, 2023 · 02704c9 · 02704c9
1 parent 8ecfa16
commit 02704c9
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/shiny/text/caret.go b/shiny/text/caret.go
@@ -602,10 +602,7 @@ func layout(f *Frame, l int32) {
 			if r == ' ' {
 				breakPoint = reader.bAndK()
 			}
-			a, ok := f.face.GlyphAdvance(r)
-			if !ok {
-				panic("TODO: is falling back on the U+FFFD glyph the responsibility of the caller or the Face?")
-			}
+			a, _ := f.face.GlyphAdvance(r)
 			advance += a
 			if r != ' ' && advance > f.maxWidth && breakPoint.b != 0 {
 				breakLine(f, l, breakPoint.b, breakPoint.k)