Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/template improved comparison error addresses issue #71421 #71431

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

text/template improved comparison error addresses issue #71421 #71431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c11143
text/template improved comparison error addresses issue #71421
diegolara93 Jan 24, 2025
3972ea6
removed .idea and handled second case (eq function)
diegolara93 Jan 25, 2025
e50b7eb
removed .idea and handled second case (eq function)
diegolara93 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/text/template/funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ func eq(arg1 reflect.Value, arg2 ...reflect.Value) (bool, error) {
truth = arg.Int() >= 0 && arg1.Uint() == uint64(arg.Int())
default:
if arg1.IsValid() && arg.IsValid() {
return false, errBadComparison
return false, fmt.Errorf("incompatible types for comparison: %v and %v", arg1.Type(), arg.Type())
}
}
} else {
Expand Down Expand Up @@ -553,7 +553,7 @@ func lt(arg1, arg2 reflect.Value) (bool, error) {
case k1 == uintKind && k2 == intKind:
truth = arg2.Int() >= 0 && arg1.Uint() < uint64(arg2.Int())
default:
return false, errBadComparison
return false, fmt.Errorf("incompatible types for comparison: %v and %v", arg1.Type(), arg2.Type())
}
} else {
switch k1 {
Expand Down