Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsrftoken: correct semantics of time vs now variable #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alephoverflow
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@alephoverflow
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 6, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 6886b33) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/171077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 137fa75) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/171077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 198fd65) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/171077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3: Run-TryBot+1

This doesn't look like it compiles now. Please run tests locally before updating.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a4b5aae4


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/1c00deea/freebsd-amd64-12_0_f95fa1c9.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

9 of 9 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1c00deea/freebsd-amd64-12_0_f95fa1c9.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1c00deea/openbsd-amd64-64_21e52759.log
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/2c5363d9/linux-amd64_689be0a3.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1c00deea/linux-amd64_ab1571d7.log
Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/ac02fdec/linux-amd64_6042bba8.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/1c00deea/linux-386_27b92c77.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1c00deea/linux-amd64-race_2a6062cb.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1c00deea/windows-amd64-2016_75e58681.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1c00deea/windows-386-2008_8d622b52.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a4b5aae4


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/1c00deea/freebsd-amd64-12_0_f95fa1c9.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result-1

9 of 9 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1c00deea/freebsd-amd64-12_0_f95fa1c9.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1c00deea/openbsd-amd64-64_21e52759.log
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/2c5363d9/linux-amd64_689be0a3.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1c00deea/linux-amd64_ab1571d7.log
Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/ac02fdec/linux-amd64_6042bba8.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/1c00deea/linux-386_27b92c77.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1c00deea/linux-amd64-race_2a6062cb.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1c00deea/windows-amd64-2016_75e58681.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1c00deea/windows-386-2008_8d622b52.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171077.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants