http2: Fix SETTINGS_HEADER_TABLE_SIZE handling in client #67
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 7540 Section 6.5.2 the SETTINGS frame with parameter SETTINGS_HEADER_TABLE_SIZE allows the sender to inform the remote endpoint the maximum size of the dynamic table for HPACK. The encoder can use any size equal or less than this value.
This is not handled properly in Go HTTP2 client when a server sends this SETTINGS frame, causing header compression failures on subsequent requests that lead to protocol errors, GOAWAY and RST_STREAM failures. This PR fixes this behavior by addressing the handling of this parameter.