http2: export CloseIdleConnections in client connection pool #71
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http2 transport allows stub of
ClientConnPool
, but bothclientConnPoolIdleCloser
interface and itscloseIdleConnections()
method are private. This makes the stubbedClientConnPool
implementation not able to implementcloseIdleConnections()
. As a result, it will be a no-op whenthe transport call
transport.CloseIdleConnections()
.Therefore, exporting
CloseIdleConnections()
method is needed. ExportingClientConnPoolIdleCloser
interface is technically not needed, but it makes the API contract more explicit, and allows the stubbed implementation to do something like: