-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: support JoinSourceSpecificGroup and LeaveSourceSpecificGroup for… #79
base: master
Are you sure you want to change the base?
net: support JoinSourceSpecificGroup and LeaveSourceSpecificGroup for… #79
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
… Windows JoinSourceSpecificGroup and LeaveSourceSpecificGroup are not implemented on Windows. This implementation uses IP_ADD_SOURCE_MEMBERSHIP and the IP_DROP_SOURCE_MEMBERSHIP from the Windows API https://docs.microsoft.com/en-us/windows/win32/winsock/ipproto-ip-socket-options Fixes #40317
a0ee1e3
to
c9ae23c
Compare
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: c9ae23c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/244479 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/244479. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/244479. |
net/ipv4: Support JoinSourceSpecificGroup and LeaveSourceSpecificGroup for Windows
This implementation adds the socket options IP_ADD_SOURCE_MEMBERSHIP and IP_DROP_SOURCE_MEMBERSHIP to the list of the sockopts supported on Windows.
It uses Winsock the same API used in the already existing JoinGroup() and LeaveGroup() functions.
Fixes #40317