x/net/http2:Enable HTTP/2 CLIENTs to receive and send unknown frames #80
+542
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2020 15:26
Signed-off-by: Yang Song <[email protected]>
Signed-off-by: soya3129 <[email protected]>
|
This PR (HEAD: e3b5b50) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/244800 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables HTTP/2 CLIENTs to receive and send unknown frames. The basic idea is to add unknown frame handling in request.Body and response.Body. If the APIs look OK, I will add more tests.
Note that, this PR is for client side review only. The change is in transport.go and transport_test.go. This PR also includes change on the server side in order to run tests, and those server side change is under review in #78, and can be ignored for review in this PR. Those server side change includes server.go, server_test.go, frame.go, write.go.
Thank @tombergan for the initial feedback!
For golang/go#40359