Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple: Add new endpoint of Apple Sign-in #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

apple: Add new endpoint of Apple Sign-in #386

wants to merge 2 commits into from

Conversation

cixtor
Copy link

@cixtor cixtor commented Jun 9, 2019

Apple’s new “Sign-in with Apple” service announced during WWDC 2019 is based on OAuth 2.0 and OIDC (OpenID Connect) plus JWT for the application credentials. The public keys to verify the JSON Web Token (JWT) signature are available here. We can validate the authorization grant code with Apple to obtain tokens or validate an existing refresh token using this endpoint. And the documentation for the token response is available here.

@gopherbot
Copy link
Contributor

This PR (HEAD: 0daeb82) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/181478 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Per the policy documented at https://github.com/golang/oauth2#policy-for-new-packages we no longer accept mini packages for just endpoints.

Feel free to add this to a new "endpoints" package, so the symbol would be "endpoints.AppleSignIn" for example.


Please don’t reply on this GitHub thread. Visit golang.org/cl/181478.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b3ec657) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/181478 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants