-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth2: added shopify endpoint and request validation #404
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 111c775) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/213132 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/213132. |
Message from Brad Fitzpatrick: Patch Set 1: We're not accepting new oauth2 packages: https://github.com/golang/oauth2/#policy-for-new-packages Instead, we're adding a new "endpoints" package in: https://go-review.googlesource.com/c/oauth2/+/212223 So this will need to be updated to use that. Or feel free to add the endpoints package in this change with just the Shopify variable for now. Please don’t reply on this GitHub thread. Visit golang.org/cl/213132. |
Message from Brad Fitzpatrick: Patch Set 1: The endpoints package is now submitted. Please move this variable to there. Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/213132. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/213132. |
No description provided.