Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow making raw HTTP POST requests to the authz server #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

misberner
Copy link

This PR adds functionality to make token-style HTTP requests to an arbitrary endpoint of the authz server, instead of just for retrieving tokens.

Use case: the main motivation was to support for OAuth2 token revocation per RFC7009. The token revocation endpoint requires client credentials, and implementing it outside of this library requires effectively re-implementing the auth style auto-sensing & caching.

This seemed the most convenient way of leveraging the library for token revocation. If desired, I can also make this less general to only support token revocation, but a.o.t. this would require figuring out the revocation URLs for all supported providers, which is outside my current time budget.

@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: d2a14ae) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/277272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/277272.
After addressing review feedback, remember to publish your drafts!

@misberner misberner force-pushed the mi-raw-http-requests branch from d2a14ae to 0b4d90a Compare September 4, 2021 01:03
@gopherbot
Copy link
Contributor

This PR (HEAD: 0b4d90a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/277272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants