authhandler: Add authCodeOpts param to TokenSource() #492
Conversation
jalavosus
force-pushed
the
authhandler_opts
branch
from
fe207be to
05e614e
Compare
jalavosus
changed the title
|
This PR (HEAD: 05e614e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/312810 to see it. Tip: You can toggle comments from me using the |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/312810. |
Refactor the signature of function TokenSource(), adding the variadic parameter `authCodeOpts`, which allows the caller to pass extra options to the OAuth authorization flow step. Refactor authHandlerSource struct to store the above-mentioned AuthCodeOptions, and pass them to `source.config.AuthCodeURL` when necessary.
`TestTokenExchange_Success` now runs in two parts; one check is the exact same check as was present before this commit, while the second test passes a "duration" AuthCodeOption to TokenSource() and checks that the same duration is returned by the test http server.
jalavosus
force-pushed
the
authhandler_opts
branch
from
05e614e to
d8af8b0
Compare
|
This PR (HEAD: d8af8b0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/312810 to see it. Tip: You can toggle comments from me using the |
Certain implementations of OAuth2 (such as Reddit) have extra parameters
available as part of their OAuth2 flow. This commit adds the variadic
parameter
authCodeOptsto the TokenSource function in authhandler,allowing a caller to pass as many of these extra URL parameters as they
want or need.
Tests in the authhandler package have also been updated to reflect this
change.
Does this commit introduce any breaking changes?
No. The new parameter is variadic, as are its uses, which means that
existing code will not be affected by this change.
** Related Issue on Github **
#491