Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP client context message to TokenSource #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeviHarrison
Copy link

While the other two methods of obtaining a token in the clientcredentials package, Client and Token, have the following message:

The provided context optionally controls which HTTP client is returned. See the oauth2.HTTPClient variable.

the third, TokenSource, does not, implying that the context can not control the HTTP client that is returned. This isn't true though, as Token uses TokenSource (https://cs.opensource.google/go/x/oauth2/+/2bc19b11:clientcredentials/clientcredentials.go;l=55-58;drc=80673b4a4bfc6c2c58a0b44cf9106913fe293994). So, we should have the same message for TokenSource.

@google-cla google-cla bot added the cla: yes label Oct 9, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 9a204c4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/354950 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/354950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from JBD (DO NOT USE):

Patch Set 1: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from JBD (DO NOT USE):

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354950.
After addressing review feedback, remember to publish your drafts!

The message is present for the other two methods of retrieving the token, and applies to this one too.

Signed-off-by: Levi Harrison <[email protected]>
@LeviHarrison LeviHarrison force-pushed the http-client-context-doc branch from 9a204c4 to c02fe4c Compare November 17, 2021 13:00
@gopherbot
Copy link
Contributor

This PR (HEAD: c02fe4c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/354950 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Levi Harrison:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354950.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Levi Harrison:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354950.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants