-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP client context message to TokenSource
#523
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 9a204c4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/354950 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/354950. |
Message from JBD (DO NOT USE): Patch Set 1: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/354950. |
Message from JBD (DO NOT USE): Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/354950. |
The message is present for the other two methods of retrieving the token, and applies to this one too. Signed-off-by: Levi Harrison <[email protected]>
9a204c4
to
c02fe4c
Compare
This PR (HEAD: c02fe4c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/354950 to see it. Tip: You can toggle comments from me using the |
Message from Levi Harrison: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/354950. |
Message from Levi Harrison: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/354950. |
While the other two methods of obtaining a token in the
clientcredentials
package,Client
andToken
, have the following message:the third,
TokenSource
, does not, implying that the context can not control the HTTP client that is returned. This isn't true though, asToken
usesTokenSource
(https://cs.opensource.google/go/x/oauth2/+/2bc19b11:clientcredentials/clientcredentials.go;l=55-58;drc=80673b4a4bfc6c2c58a0b44cf9106913fe293994). So, we should have the same message forTokenSource
.