Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ReadPasswordWithContext #12

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grisu48
Copy link

@grisu48 grisu48 commented Mar 6, 2023

Introduced the ReadPasswordWithContext function that allows to read a password from the terminal with support for cancellation. This is a suggestion to address golang/go#31180.

This is a work-in-progress PR for collecting the first feedback. Please do not merge!

Introduced the ReadPasswordWithContext function that allows to read a
password from the terminal with support for cancellation.

Signed-off-by: grisu48 <[email protected]>
@grisu48
Copy link
Author

grisu48 commented Mar 6, 2023

Hey there, this PR is an attempt to resolve golang/go#31180. The current state is notready but I'd like to collect the first feedback, if this the idea is in principle worth following up and if someone has a bett
er approach to resolve the issue.

Two notes on this PR:

  • The Windows version does not work currently and I'm stuck there. The used f := os.NewFile(uintptr(h), "stdin") construct is not closeable and AFAICS does Windows not support nonblocking IO access to the terminal. Any suggestion on how
    to unblock this is more than welcome
  • The Unix reader works by nonblocking UI and polling, which is not ideal. If anyone has an idea for an alternative approach ...

@gopherbot
Copy link
Contributor

This PR (HEAD: 900d043) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/term/+/473635 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/473635.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants