gopls: added method docs to hover info #487
Open
+74
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change also includes a jump to definition feature for all methods.The change is quite fail-safe, such that if it fails in any way, it will still display the hover info without the method docs(as before). The change is localised to the the gopls/internal/golang/hover.go file, in function hover and formatHover.
I should also mention that it does not alter the method displayed or it order, it just add the method docs (if any) and a jump to page source url to the hover info.
Fixes golang/go#66721
Fixes golang/go#66721