Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/ssa: remove outdated doc in CreatePackage and add respective test cases #518

Closed
wants to merge 1 commit into from
Closed

go/ssa: remove outdated doc in CreatePackage and add respective test cases #518

wants to merge 1 commit into from

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Sep 12, 2024 •
edited
Loading

It also removes the deprecated loader package and uses packages and txtar to load the package for testing. Now all packages are created under a go module.

@gopherbot
Copy link
Contributor

This PR (HEAD: 7518934) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/612718.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1: Hold+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 1:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: c058a06) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/612718.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 2: Hold+1

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@xieyuschen
go/ssa: remove outdated doc in CreatePackage and add respective test …
f002efa 
…cases

It also removes the deprecated loader package and uses packages and
txtar to load the package for testing. Now all packages are created
under a go module.
@xieyuschen xieyuschen force-pushed the panic-when-create-pkg-on-built-program branch from c058a06 to f002efa Compare September 16, 2024 13:57
@gopherbot
Copy link
Contributor

This PR (HEAD: f002efa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/612718.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@xieyuschen xieyuschen changed the title go/ssa: panic when adding pkg after building any pkg in the program go/ssa: remove outdated doc in CreatePackage and add respective test cases Sep 16, 2024
@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 2:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 5: Hold+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Xie Yuchen:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/612718.
After addressing review feedback, remember to publish your drafts!

@xieyuschen
Copy link
Contributor Author

close it as i'm going to split these changes into smaller pieces.

@xieyuschen xieyuschen closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xieyuschen @gopherbot