-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: render package documentation when hovering over imported package name identifiers #559
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 940cfd5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643516. Important tips:
|
Message from Grant Smith: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Ethan Reesor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
This PR (HEAD: a7be2b0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643516. Important tips:
|
Message from Grant Smith: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Grant Smith: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Ethan Reesor: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-21T22:59:34Z","revision":"bdf07dc91e6d43dffc0ef64d71cccdd8f984e601"} Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Ethan Reesor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_tools-go1.21-linux-amd64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
This PR (HEAD: 0e0bba1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643516. Important tips:
|
Message from Gopher Robot: Patch Set 3: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
This PR (HEAD: c1d90f1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643516. Important tips:
|
This PR (HEAD: a743363) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643516. Important tips:
|
Message from Grant Smith: Patch Set 5: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Grant Smith: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Robert Findley: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-04T14:12:36Z","revision":"38cf0182e5894a3d5cd61df657a42dc18b742f0c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Robert Findley: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjob golang/try/x_tools-go1.21-linux-amd64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Grant Smith: Patch Set 5: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Robert Findley: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Ethan Reesor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Message from Robert Findley: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643516. |
Closes Issue golang/go#71248