-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tour: updated description for if
statement in flowcontrol article
#1171
tour: updated description for if
statement in flowcontrol article
#1171
Conversation
This PR (HEAD: cd148ab) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tour/+/312709 to see it. Tip: You can toggle comments from me using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggestion to include in this PR, hoping to improve the syntax and add a natural format to the description.
content/flowcontrol.article
Outdated
@@ -46,8 +46,8 @@ If you omit the loop condition it loops forever, so an infinite loop is compactl | |||
|
|||
* If | |||
|
|||
Go's `if` statements are like its `for` loops; the expression need not be | |||
surrounded by parentheses `(`)` but the braces `{`}` are required. | |||
The expression need not be surrounded by parentheses `(`)` in Go's `if` statement and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expression need not be surrounded by parentheses `(`)` in Go's `if` statement and | |
The expression does not need to be surrounded by parentheses `(`)` in Go's `if` statement and |
Existing article is misleading, in new change clear description is provided Fixes golang#743
cd148ab
to
3360126
Compare
This PR (HEAD: 3360126) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tour/+/312709 to see it. Tip: You can toggle comments from me using the |
seems like the tour repo has been moved. Now, what will happen to this issues @spyros-uk. |
This PR is being closed because golang.org/cl/312709 has been abandoned. Closing because x/tour content moved to x/website (see CL 324309), leaving only a few supporting Go packages. If this change still applies, it'd need to be re-sent it to x/website. Thanks. |
Existing article is misleading, in new change clear description is provided
Fixes #743