src/goMain: export a small API #1642
Conversation
google-cla
bot
added
the
cla: yes
|
This PR (HEAD: 7559179) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/336509 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 2: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
|
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
|
Message from kokoro: Patch Set 2: TryBot-Result+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
|
Message from Ethan Reesor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
|
Message from Hyang-Ah Hana Kim: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
|
Message from Ethan Reesor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
firelizzard18
force-pushed
the
export-api
branch
from
7559179 to
465158c
Compare
|
This PR (HEAD: 465158c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/336509 to see it. Tip: You can toggle comments from me using the |
|
Message from Ethan Reesor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336509. |
firelizzard18
force-pushed
the
export-api
branch
from
465158c to
a3c22b7
Compare
|
This PR (HEAD: a3c22b7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/336509 to see it. Tip: You can toggle comments from me using the |
|
/comments off |
firelizzard18
force-pushed
the
export-api
branch
from
3f6650c to
0171541
Compare
Exports a function for use by other extensions. When I'm creating a Go-related VSCode extension, being able to reuse this extension's configuration and certain helper functions would be very useful. Additionally, users expect Go-related extensions to respect `go.*` configuration options, and have reported issues when they don't. This change exports `getBinPath`. With this function, Go-related extensions don't have to reinvent the wheel when it comes to installing and configuring Go tools. Updates #233 Change-Id: I9edf7f87437492182e8562aa107b643ca01a1202 GitHub-Last-Rev: 0171541 GitHub-Pull-Request: #1642 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/336509 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Suzy Mueller <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Exports a function for use by other extensions. When I'm creating a
Go-related VSCode extension, being able to reuse this extension's
configuration and certain helper functions would be very useful.
Additionally, users expect Go-related extensions to respect
go.*configuration options, and have reported issues when they don't. This
change exports
getBinPath. With this function, Go-relatedextensions don't have to reinvent the wheel when it comes to
installing and configuring Go tools.
Updates #233