src: prompt user to file an issue after gopls crashes #34
Conversation
Change-Id: Iae5b6e442f2ffd6b99b7f21b9d1e82ab598d0740
googlebot
added
the
cla: yes
|
This PR (HEAD: 7868436) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/233325 to see it. Tip: You can toggle comments from me using the |
stamblerre
changed the title
|
Message from Rebecca Stambler: Patch Set 2: This CL is mostly a copy of CL 232863. I wanted to separate out from this larger refactor. Please don’t reply on this GitHub thread. Visit golang.org/cl/233325. |
Change-Id: I563d69145a03ef890e3179dd5a4930661658599b
|
This PR (HEAD: f43e680) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/233325 to see it. Tip: You can toggle comments from me using the |
And also fix test failure detection. Previously, only the integration test failure was counted. Change-Id: Ia39918e7c950bd7754f6641429c0ccaa87bf467f GitHub-Last-Rev: 34f4e01 GitHub-Pull-Request: #33 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/233319 Reviewed-by: Rebecca Stambler <[email protected]>
And change back to the version from upstream. That will ease the sync process and less confusing during migration. Change-Id: I6b3a7e2157bdc586f9f5052ec1db46a86bbaed01 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/232459 Reviewed-by: Rebecca Stambler <[email protected]>
Until the gopls test becomes less flaky, don't block the nightly release. Update #37 Change-Id: I8016d26f8775c247576da7ea39a69858579ce3ec GitHub-Last-Rev: 793867b GitHub-Pull-Request: #38 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/233558 Reviewed-by: Rebecca Stambler <[email protected]>
|
Message from Hyang-Ah Hana Kim: Patch Set 4: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/233325. |
Change-Id: Iae5b6e442f2ffd6b99b7f21b9d1e82ab598d0740
Change-Id: I563d69145a03ef890e3179dd5a4930661658599b
Change-Id: I4c39e8fd398a24e557dc17eee2419022a6c11746
|
This PR (HEAD: df990d7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/233325 to see it. Tip: You can toggle comments from me using the |
|
Message from Rebecca Stambler: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/233325. |
This change adds support for filing a gopls issue when the user restarts `gopls` or when `gopls` crashes. In a follow-up, we might be able to suggest attaching the `gopls` log. The suggestion to file an issue after a manual restart is disabled by default for now. We can enable it once gopls is more stable. I'm moving the bulk of https://golang.org/cl/232863 here so that I can work on refactoring the env variables separately without causing a ton of merge conflicts. Change-Id: I0c98bd526562dd50bdc7b127ddfb95f7de926075 GitHub-Last-Rev: df990d7 GitHub-Pull-Request: #34 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/233325 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
|
This PR is being closed because golang.org/cl/233325 has been merged. |
This change adds support for filing a gopls issue when the user restarts
goplsor whengoplscrashes. In a follow-up, we might be able to suggest attaching thegoplslog.The suggestion to file an issue after a manual restart is disabled by default for now. We can enable it once gopls is more stable. I'm moving the bulk of https://golang.org/cl/232863 here so that I can work on refactoring the env variables separately without causing a ton of merge conflicts.