You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lots of links in the tour using origin-relative links on the assumption they will be used at https://go.dev/, which works out badly if the tour is being used offline. For example we have the append documentation going to
http://127.0.0.1:3999/pkg/builtin/#append
rather than
https://go.dev/pkg/builtin/#append
Lots of pkg/ links, also /blog, /doc, /talks, /cmd, & / directly.
The text was updated successfully, but these errors were encountered:
crisman
added a commit
to crisman/golang_website
that referenced
this issue
Mar 13, 2023
Lots of links in the tour use origin-relative links on the assumption
they will be used at "https://go.dev/", which works out badly if the
tour is being used offline. Links inside of "#appengine:" don't need to
be updated as they will be running inside the normal location. Also
don't have to update links starting with "/tour" as they will work in
the offline and appengine modes.
I did consider updating the links to the place they currently redirect
for links like "https://go.dev/pkg/builtin" which ends up at
"https://pkg.go.dev/builtin" but it is redirecting with 307 Temporary
Redirect (unlike the 301 Moved Permanently "https://golang.org/" gets) so I
avoided those updates.
Update origin-relative links that will appear offline to be absolute
https://go.dev links.
Fixesgolang/tour#1463
Context: https://go.dev/tour/moretypes/15
Lots of links in the tour using origin-relative links on the assumption they will be used at https://go.dev/, which works out badly if the tour is being used offline. For example we have the append documentation going to
rather than
Lots of
pkg/
links, also/blog
,/doc
,/talks
,/cmd
, &/
directly.The text was updated successfully, but these errors were encountered: