tour: absolute links so they work in offline tour #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of links in the tour use origin-relative links on the assumption they will be used at "https://go.dev/", which works out badly if the tour is being used offline. Links inside of "#appengine:" don't need to be updated as they will be running inside the normal location. Also don't have to update links starting with "/tour" as they will work in the offline and appengine modes. I did consider updating the links to the place they currently redirect for links like "https://go.dev/pkg/builtin" which ends up at "https://pkg.go.dev/builtin" but it is redirecting with 307 Temporary Redirect (unlike the 301 Moved Permanently "https://golang.org/" gets) so I avoided those updates. Update origin-relative links that will appear offline to be absolute https://go.dev links. Fixes golang/tour#1463
|
This PR (HEAD: 9a08ddb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/475777 to see it. Tip: You can toggle comments from me using the |
|
Fixes golang/tour#1473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of links in the tour use origin-relative links on the assumption they will be used at "https://go.dev/", which works out badly if the tour is being used offline. Links inside of "#appengine:" don't need to be updated as they will be running inside the normal location. Also don't have to update links starting with "/tour" as they will work in the offline and appengine modes.
I did consider updating the links to the place they currently redirect for links like "https://go.dev/pkg/builtin" which ends up at "https://pkg.go.dev/builtin" but it is redirecting with 307 Temporary Redirect (unlike the 301 Moved Permanently "https://golang.org/" gets) so I avoided those updates.
Update origin-relative links that will appear offline to be absolute https://go.dev links.
Fixes golang/tour#1463