Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment from hello example #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterhellberg
Copy link

Remove comment in order to reduce the number of wasted lines in https://go.dev/play/
(The current design shows fewer lines of code than the old version of the playground)

Users would otherwise have to manually remove these each time they want to share a snippet on the playground.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Nov 29, 2021
@peterhellberg
Copy link
Author

Signed the CLA after opening the PR.

@dolmen
Copy link

dolmen commented Nov 29, 2021

I think that the comment is in fact useful for new comers. It might also be useful when sending a Playground link (after code edit) to someone else, so this would not be a problem to many people who start from this example.

I have much concerns about the screen space wasted with the new UI of the Go Playground (2 third of screen wasted on desktop to show other things than the code) but the example code is not a problem from my point of view.

Remove comment in order to reduce the number of wasted lines in <https://go.dev/play/>
(The current design shows fewer lines of code than the old version of the playground)

Users would otherwise have to manually remove these each time they want to share a snippet on the playground.
@google-cla google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Nov 29, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: ac3e38f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/367474 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/367474.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants