tour: Reader has method not func #196
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interfaces do not define func as in the current text of "Readers"
("/tour/methods/21"). The interface specifies a list of methods, just Read() in
this case. It is confusing to say "interface has a Read method" and then show a
code line defining what would be a method on a type that impliments the
interface.
Changed the article text to follow the pattern of "Stringers"
("/tour/methods/17") which shows the interface definition in the code block. In
following this pattern I moved the code just below that text about the package
io and its io.Reader interface.
part 1/2
Interfaces do not define func as in the current text of "Readers"
("/tour/methods/21"). The interface specifies a list of methods, just Read() in
this case. It is confusing to say "interface has a Read method" and then show a
code line defining what would be a method on a type that impliments the
interface.
Changed the article text to follow the pattern of "Stringers"
("/tour/methods/17") which shows the interface definition in the code block. In
following this pattern I moved the code just below that text about the package
io and its io.Reader interface.
part 2/2
Fixes golang/tour#1450
|
This PR (HEAD: 93f2846) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/471176 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces do not define func as in the current text of "Readers"
("/tour/methods/21"). The interface specifies a list of methods, just Read() in
this case. It is confusing to say "interface has a Read method" and then show a
code line defining what would be a method on a type that impliments the
interface.
Changed the article text to follow the pattern of "Stringers"
("/tour/methods/17") which shows the interface definition in the code block. In
following this pattern I moved the code just below that text about the package
io and its io.Reader interface.
Fixes golang/tour#1450
Change is in two commits to try to avoid stomping on the blame log for the line between "The Go standard library contains...". Not sure this was successful, useful, or needed.