tour: clear up source/destination slice confusion #209
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "tour/moretypes/10" ("Slice defaults") the phrase "the length of the
slice for the high bound" has generated more than a dozen issues, mostly
wanting to replace "slice" with "array". The confusion is that when
slicing, the word "slice" is not well defined we will have an output
slice (result of the slice expression) and may well have a input slice
(e.g. in the example code in "slice-bounds.go"). The spec uses the
phrase "length of the sliced operand" for the high bound.
Change wording of slice default upper bound to phrase used in "ref/spec"
and reword the slide text to point out what the "sliced operands" are in
the slide and program examples.
Fixes golang/tour#1386
Fixes golang/tour#879
Fixes golang/tour#855
Fixes golang/tour#821
Fixes golang/tour#679
Fixes golang/tour#448
Fixes golang/tour#182
See golang/tour#182 for context and links to many of the issues.
|
This PR (HEAD: c65e21b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/475216 to see it. Tip: You can toggle comments from me using the |
|
Also fixes golang/tour#1337 |
|
Also fixes golang/tour#1483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "tour/moretypes/10" ("Slice defaults") the phrase "the length of the slice for the high bound" has generated more than a dozen issues, mostly wanting to replace "slice" with "array". The confusion is that when slicing, the word "slice" is not well defined we will have an output slice (result of the slice expression) and may well have a input slice (e.g. in the example code in "slice-bounds.go"). The spec uses the phrase "length of the sliced operand" for the high bound.
Change wording of slice default upper bound to phrase used in "ref/spec" and reword the slide text to point out what the "sliced operands" are in the slide and program examples.
Fixes golang/tour#1386
Fixes golang/tour#879
Fixes golang/tour#855
Fixes golang/tour#821
Fixes golang/tour#679
Fixes golang/tour#448
Fixes golang/tour#182
See golang/tour#182 for context and links to many of the issues.