New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_content/doc: Missing "the" in sentence #211

Closed

iamrajiv wants to merge 1 commit into golang:master from iamrajiv:iamrajiv-patch-1

Contributor

iamrajiv commented Mar 13, 2023

Fixes: golang/go#58991


          Update effective_go.html

8c57894

Contributor

gopherbot commented Mar 13, 2023

This PR (HEAD: 8c57894) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/475775 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Mar 13, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/475775.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 16, 2023

Message from Rob Pike:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475775.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 16, 2023

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475775.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 16, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475775.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 16, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/475775.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          _content/doc: Missing "the" in sentence

e74720e

Fixes: golang/go#58991

Change-Id: I1b40b5b8641ca5cd3ce17195b167c24ecfca8124
GitHub-Last-Rev: 8c57894
GitHub-Pull-Request: #211
Reviewed-on: https://go-review.googlesource.com/c/website/+/475775
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>

Contributor

gopherbot commented Mar 17, 2023

This PR is being closed because golang.org/cl/475775 has been merged.

gopherbot closed this

iamrajiv deleted the iamrajiv-patch-1 branch

March 17, 2023 05:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet