Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content/static/doc: make clear when pseudo versions will be used #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

content/static/doc: make clear when pseudo versions will be used #34

wants to merge 1 commit into from
+3 −3

Conversation

HuKeping
Copy link

@HuKeping HuKeping commented Jan 8, 2021 •
edited
Loading

The docs is misleading because even if a semantic version tag is
provided, go would also encodes it to a pseudo version format, for
example:

  • 1.2.3 is a semantic version tags as per semver spec 2.0 which
    go will translate it to a pseudo version.
  • v1.2.3 is the canonical version format which go mod love most.

Signed-off-by: Hu Keping [email protected]

@HuKeping
content/static/doc: make clear when pseudo versions will be used
3765ee6 
The docs is misleading because even if a semantic version tag is
provided, go would also encodes it to a pseudo version format, for
example:
- 1.2.3 is a semantic version tags as per semver spec 2.0[1] which
  go will translate it to a pseudo version.
- v1.2.3 is the canonical version format which go mod love most.

[1]: https://semver.org/spec/v2.0.0.html

Signed-off-by: Hu Keping <[email protected]>
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 8, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 3765ee6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/282574 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/282574.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/282574.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/282574.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/282574.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HuKeping @gopherbot