Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4 #123

Merged
merged 37 commits into from
Sep 18, 2024
Merged

v0.4 #123

merged 37 commits into from
Sep 18, 2024

Conversation

goniszewski
Copy link
Owner

No description provided.

goniszewski and others added 30 commits May 29, 2024 21:04
)

* feat: create DB connection, draft schemas

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: add initial local storage support, work on DB impl., minor changes

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: rewrite entities fetching, improve DB schema

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: integrate Lucia for auth, update DB schema, work on file server

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: progressing auth flow, update types, DB schema

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: update DB schema, rework DB types, further transition

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: add support for file uploads, update DB schema, improve auth flow

Signed-off-by: Robert Goniszewski <[email protected]>

* chore: remove test PB data

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: various updates of logic

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: update DB schema, improve file upload handling

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: add support for user profile pictures, update DB schema

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: add support for user picture uploads, update DB schema

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor(api): migrate category and tag endpoints to use database repositories

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(database): update schema and add cascade delete for user relations

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(deps): update dependencies and refactor database schema

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(metadata): replace metascraper with url-metadata

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: fix file uploads & resolving, types, switching theme etc

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: better typing and serialization

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: switch to unixepoch() for timestamp defaults; additional changes

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(database): update schema and repositories for consistent timestamps

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(bookmarks): improve tag handling and form data processing

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(auth): implement API-based authentication and refactor auth flow

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(bookmarks): improve bookmark creation and update processes; storing files

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor: improve file handling; remove unused imports

Signed-off-by: Robert Goniszewski <[email protected]>

* fix(storage): improve file extension handling for icon and SVG types

Signed-off-by: Robert Goniszewski <[email protected]>

* feat: prevent users from signing up when disabled in config; update README

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(ci): add develop branch and preview releases

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor(bookmarks): remove unused import and add Storage import

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor(docker): remove PocketBase and fix Docker build issues

Signed-off-by: Robert Goniszewski <[email protected]>

---------

Signed-off-by: Robert Goniszewski <[email protected]>
Signed-off-by: Robert Goniszewski <[email protected]>
…ation; update compose file

Signed-off-by: Robert Goniszewski <[email protected]>
#120)

* refactor(metadata): improve urlMetadataScraper function and error handling; fix error on missing

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(metadata): improve icon URL validation and error handling

Signed-off-by: Robert Goniszewski <[email protected]>

* fix(auth): improve login error handling and messages

Signed-off-by: Robert Goniszewski <[email protected]>

---------

Signed-off-by: Robert Goniszewski <[email protected]>
Signed-off-by: Robert Goniszewski <[email protected]>
goniszewski and others added 6 commits September 13, 2024 20:57
* feat(data-migration): start working on PB data migration

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(metadata): enhance performance logging and URL display

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor(utils): enhance performance logging format

Signed-off-by: Robert Goniszewski <[email protected]>

* chore(deps): update development and production dependencies

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(migration): implement data migration UI and functionality

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(database): update foreign key constraints for cascading deletes

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(bookmark): optimize image storage and improve first-time user experience

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(various): finish migration tool preview, improve file handling

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(setup): simplify installation process and update dependencies

Signed-off-by: Robert Goniszewski <[email protected]>

* chore: release v0.4.0-pre.4

---------

Signed-off-by: Robert Goniszewski <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

RUN apt-get update && apt-get install -y python3 python3-pip wget && rm -rf /var/lib/apt/lists/*
COPY . /app
FROM oven/bun AS base
RUN apt-get update && apt-get install -y python3 python3-pip wget build-essential && rm -rf /var/lib/apt/lists/*

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
Comment on lines +28 to +32
console.log('connectToPb', {
pbUrl,
email,
password
});

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
an access to password
as clear text.
This logs sensitive data returned by
an access to password
as clear text.

Copilot Autofix AI about 2 months ago

To fix the problem, we need to ensure that sensitive information such as passwords and emails are not logged in clear text. Instead, we can log non-sensitive information or mask the sensitive parts of the data. Specifically, we should remove or mask the logging of password and email on line 28.

  • Remove the logging of sensitive information.
  • Ensure that the functionality remains unchanged by only modifying the logging statements.
  • The changes will be made in the file src/routes/migrate/+page.server.ts.
Suggested changeset 1
src/routes/migrate/+page.server.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/routes/migrate/+page.server.ts b/src/routes/migrate/+page.server.ts
--- a/src/routes/migrate/+page.server.ts
+++ b/src/routes/migrate/+page.server.ts
@@ -29,4 +29,4 @@
 			pbUrl,
-			email,
-			password
+			email: email ? email.replace(/(.{2}).+(@.+)/, '$1***$2') : '',
+			password: password ? '***' : ''
 		});
EOF
@@ -29,4 +29,4 @@
pbUrl,
email,
password
email: email ? email.replace(/(.{2}).+(@.+)/, '$1***$2') : '',
password: password ? '***' : ''
});
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Signed-off-by: Robert Goniszewski <[email protected]>
@goniszewski goniszewski merged commit d1c552d into main Sep 18, 2024
2 checks passed
@goniszewski goniszewski deleted the develop branch September 18, 2024 20:09
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@goniszewski goniszewski restored the develop branch September 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant