Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disabling dead code elimination when using Equal #374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pgimalac
Copy link

@pgimalac pgimalac commented Feb 18, 2025

Partially fixes #373 (Equal only).

This PR moves code around to allow the linker to statically determine that the code using reflect.Type.Method is not reachable from the Equal function.
It replaces the type name logic of unnamed interfaces to just use reflect.Type.String() when the qualified argument of appendTypeName is false.
The only difference in the output is that there is a space added between interface and the opening bracket.

Copy link

google-cla bot commented Feb 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow linker to perform dead code elimination for programs using go-cmp
1 participant