Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build tag to avoid disabling dead code elimination #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgimalac
Copy link

Fixes #373.

This PR moves creating the string representation of an unnamed interface behind a build tag interface_string_no_reflect.

  • When the build tag is not used, nothing changes.
  • When the build tag is used, just use reflect.Type.String() to get the string representation of the type. The main caveat of this implementation is that it ignores the qualified argument.

Additional notes
This works because the compiler can determine that one branch of the condition is not reachable, due to using a constant and not a variable.

Copy link

google-cla bot commented Feb 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow linker to perform dead code elimination for programs using go-cmp
1 participant