Merge pull request #158 from josephlr/cgo

Fix CGO warnings and add CI checks to prevent regression
google · Jan 26, 2022 · 938e4fa · 938e4fa
2 parents 02925fa + 51ca914
commit 938e4fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -78,6 +78,10 @@ jobs:
       uses: actions/checkout@v2
     - name: Install Linux packages
       run: sudo apt-get -y install libssl-dev libtspi-dev
+    - name: Check for CGO Warnings (gcc)
+      run: CGO_CFLAGS=-Werror CC=gcc go build ./...
+    - name: Check for CGO Warnings (clang)
+      run: CGO_CFLAGS=-Werror CC=clang go build ./...
     - name: Lint
       uses: golangci/golangci-lint-action@v2
       with:

diff --git a/simulator/internal/internal_cgo.go b/simulator/internal/internal_cgo.go
@@ -17,7 +17,7 @@ package internal
 // // Windows has linking errors when using stack protectors
 // #cgo !windows CFLAGS: -fstack-protector-all
 // // Silence known warnings from the reference code and CGO code.
-// #cgo CFLAGS: -Wno-missing-braces -Wno-empty-body -Wno-unused-variable -Wno-maybe-uninitialized
+// #cgo CFLAGS: -Wno-missing-braces -Wno-empty-body -Wno-unused-variable -Wno-uninitialized
 // // Link against the system OpenSSL
 // #cgo CFLAGS: -DDEBUG=YES
 // #cgo CFLAGS: -DSIMULATION=NO