Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OboeTester: Add input device selector to Tap To Tone #1830

Merged
merged 2 commits into from
Jun 28, 2023
Merged

OboeTester: Add input device selector to Tap To Tone #1830

merged 2 commits into from
Jun 28, 2023

Conversation

robertwu1
Copy link
Collaborator

Fixes #470

@robertwu1 robertwu1 requested a review from philburk June 16, 2023 16:40
philburk
philburk reviewed Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The intention was to just find the built-in mic and select it.
Is there an advantage in giving the user an option to pick the input from a menu?
Does it default to Built-in Mic type?

@robertwu1
Copy link
Collaborator Author

Thanks for doing this. The intention was to just find the built-in mic and select it. Is there an advantage in giving the user an option to pick the input from a menu? Does it default to Built-in Mic type?

I was testing the PR on a Pixel 6 and it has two built-in MICs. That's why I wanted to surface all audio sources.

@philburk
Copy link
Collaborator

I was testing the PR on a Pixel 6 and it has two built-in MICs. That's why I wanted to surface all audio sources.

OK.

@robertwu1 robertwu1 requested a review from philburk June 27, 2023 17:20
@robertwu1 robertwu1 merged commit 9f337bf into main Jun 28, 2023
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/taptotoneinputselector branch June 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OboeTester: select built-in mic for Tap-To-Tone
2 participants
@robertwu1 @philburk