-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-hypervisor: Collect all fuzzers automatically #12935
cloud-hypervisor: Collect all fuzzers automatically #12935
Conversation
liuw is either the primary contact or is in the CCs list of projects/cloud-hypervisor. |
@likebreath do you know why the coverage build failed? It complained that the x86emul binary is not available. A few things I don't understand:
The only explanation I have right now is that task somehow disregards |
1c11eba
to
f0ae671
Compare
This eliminates the need to submit PRs to oss-fuzz every time a new fuzzer is added. Signed-off-by: Wei Liu <[email protected]>
f0ae671
to
a1eeefa
Compare
I work around the issue by always building x86emul. |
@rbradford can I go ahead and merge? |
@vitorguidi Yes - please go ahead. Thanks! |
@liuw I am glad to see this issue has been resolved. We can improve our cargo fuzz workflow to test it ahead. I believe cargo fuzz build by default only build with address sanitizer. |
For what it's worth, I build the coverage support for the fuzzers in a local branch. The local branch requires
This is what I run. I can see that Obviously oss-fuzz sets far more flags than I do. Some of the flags can be causing the issue we see here. That means unless we run oss-fuzz's build script in CH's CI, this particular issue cannot be caught. |
You can do this easily by way of CIFuzz: https://google.github.io/oss-fuzz/getting-started/continuous-integration/#continuous-integration |
No description provided.