expat: Fix build for new fuzzer xml_lpm_fuzzer
#13015
Conversation
|
hartwork is either the primary contact or is in the CCs list of projects/expat. |
hartwork
force-pushed
the
expat-fix-build
branch
3 times, most recently
from
003f5be to
f63d33d
Compare
hartwork
force-pushed
the
expat-fix-build
branch
9 times, most recently
from
2cc1c60 to
ad785cf
Compare
| @@ -1,4 +1,5 @@ | |||
| # Copyright 2016 Google Inc. | |||
| # Copyright 2025 Sebastian Pipping <[email protected]> | |||
There was a problem hiding this comment.
@vitalybuka I felt that my contribution to these files is non-trivial and significant, both in the terms of the many voluntary unpaid hours of debugging needed to produce them but also with regard to sophistication when comparing the before and after of these two files. I'm not adding that line for legal affect — legality with and without this line should be identical to my best knowledge — but for visibility, to show "I was here, I helped this project".
PS: There are other places in here with non-Google attribution lines, so I'm not alone with this, please click to expand for details.
# git rev-parse HEAD
9ece30fe7d0f42a4f09771d98fa928a846cb4a8d
# git grep Copyright | grep -v Google | grep build.sh
projects/casync/build.sh:# Copyright 2018 Red Hat Inc.
projects/cras/build.sh:# Copyright 2017 The Chromium Authors. All rights reserved.
projects/leveldb/build.sh:# Copyright 2020 Luca Boccassi <[email protected]>
projects/libjpeg-turbo/build.sh:# Copyright 2022-2023 D. R. Commander
projects/libxls/build.sh:# Copyright 2019 Evan Miller
projects/libzmq/build.sh:# Copyright 2020 Luca Boccassi <[email protected]>
projects/monero/build.sh:# Copyright 2020 The Monero Project
projects/readstat/build.sh:# Copyright 2019 Evan Miller
projects/sound-open-firmware/build.sh:# Copyright 2020 The Chromium Authors. All rights reserved.
# git grep Copyright | grep -v Google | grep Dockerfile
projects/casync/Dockerfile:# Copyright 2018 Red Hat Inc.
projects/clamav/Dockerfile:# Copyright (C) 2018 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
projects/cras/Dockerfile:# Copyright 2017 The Chromium Authors. All rights reserved.
projects/libjpeg-turbo/Dockerfile:# Copyright 2022-2023 D. R. Commander
projects/libxls/Dockerfile:# Copyright 2019 Evan Miller
projects/monero/Dockerfile:# Copyright 2020 The Monero Project
projects/readstat/Dockerfile:# Copyright 2019 Evan Miller
projects/sound-open-firmware/Dockerfile:# Copyright 2020 The Chromium Authors. All rights reserved.
projects/tpm2/Dockerfile:# Copyright 2017 The Chromium Authors. All rights reserved.What do you think?
There was a problem hiding this comment.
I don't have opinion, and will leave it to OSS-Fuzz maintainers.
There was a problem hiding this comment.
I guess to contribute here you need to accept https://cla.developers.google.com/about/google-individual
And there are Copyright related text.
There was a problem hiding this comment.
I don't have opinion, and will leave it to OSS-Fuzz maintainers.
@vitalybuka alright with me. Maybe we can CC someone individually to speed things up — do you have anyone in particular in mind? If there are sound reasons against adding that line, I can consider dropping it and would also be curious to learn about why.
I guess to contribute here you need to accept https://cla.developers.google.com/about/google-individual And there are Copyright related text.
I have signed the CLA in the past and also contributed minor fixes here in the past so no worries or open todos on that front that I'm aware of.
There was a problem hiding this comment.
I don't have opinion, and will leave it to OSS-Fuzz maintainers.
@DonggeLiu @vitorguidi can you help confirm that addition of this attribution line is alright?
Signed-off-by: Sebastian Pipping <[email protected]>
Signed-off-by: Sebastian Pipping <[email protected]>
.. for both amd64 and i386
.. for a chance at passing the bad build checker. Symptom was: > error while loading shared libraries: libstdc++.so.6: > cannot open shared object file: No such file or directory
hartwork
force-pushed
the
expat-fix-build
branch
from
ad785cf to
4849cc3
Compare
hartwork
changed the title
xml_lpm_fuzzer
| @@ -15,7 +16,13 @@ | |||
| ################################################################################ | |||
|
|
|||
| FROM gcr.io/oss-fuzz-base/base-builder | |||
| RUN apt-get update && apt-get install -y cmake docbook2x make | |||
| RUN apt-get update && apt-get install -y \ | |||
| cmake \ | |||
There was a problem hiding this comment.
Hm, how did we get proto before?
There was a problem hiding this comment.
@vitalybuka not at all, Protobuf is a new dependency upstream only since libexpat/libexpat#950 (or libexpat/libexpat#961 depending on view).
Related:
xml_lpm_fuzzer(replaces pull request #617) libexpat/libexpat#950xml_lpm_fuzzerfor-DEXPAT_OSSFUZZ_BUILD=ONlibexpat/libexpat#961