infra: build: build_project: set entrypoint explicitly in compile step #13030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow same pattern as https://github.com/google/oss-fuzz/blob/2772bd6f5d11a44d068b86b8ce7732ab9aff6eb2/infra/build/functions/target_experiment.py#L151-L154 This should also solve a problem with Chronos where the entrypoint is set to `bin/bash` already: https://github.com/google/oss-fuzz/blob/2772bd6f5d11a44d068b86b8ce7732ab9aff6eb2/infra/experimental/chronos/build_cache_local.sh#L59 Chronos needs to set it in order for the images to work locally with `helper.py`. Alternatively, we could set entrypoint in `helper.py`, I think
|
I think I have a better solution |
|
superseded by #13031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow same pattern as
oss-fuzz/infra/build/functions/target_experiment.py
Lines 151 to 154 in 2772bd6
This should also solve a problem with Chronos where the entrypoint is set to
bin/bashalready:oss-fuzz/infra/experimental/chronos/build_cache_local.sh
Line 59 in 2772bd6
Chronos needs to set it in order for the images to work locally with
helper.py.Alternatively, we could set entrypoint in
helper.py, I think