Colorize weblist output #271
+166
−25
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,15 +4,58 @@ import ( | |
| "bytes" | ||
| "os" | ||
| "path/filepath" | ||
| "reflect" | ||
| "regexp" | ||
| "runtime" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/google/pprof/internal/binutils" | ||
| "github.com/google/pprof/internal/graph" | ||
| "github.com/google/pprof/profile" | ||
| ) | ||
|
|
||
| func TestCalculatePercentiles(t *testing.T) { | ||
| for _, testCase := range []struct { | ||
|
There was a problem hiding this comment. I think there should be at least these additional test cases:
|
||
| fnodes graph.Nodes | ||
|
There was a problem hiding this comment. What does "f" in "fnodes" stand for here? |
||
| output map[float64]float64 | ||
|
|
||
| }{ | ||
| { | ||
| fnodes: []*graph.Node{}, | ||
|
There was a problem hiding this comment. Prefer nil for empty slices - https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices which is also the zero value here. |
||
| output: nil, | ||
|
There was a problem hiding this comment. Nil is the zero value for reference types, no need to have the initializer for the field. |
||
| }, | ||
| { | ||
| fnodes: []*graph.Node{ | ||
| &graph.Node{ | ||
|
There was a problem hiding this comment.
|
||
| Cum: 0, | ||
| }, | ||
| &graph.Node{ | ||
| Cum: 8, | ||
| }, | ||
| }, | ||
| output: map[float64]float64{10: 0, 20: 0, 40: 0, 60: 8, 80: 8}, | ||
| }, | ||
| { | ||
| fnodes: []*graph.Node{ | ||
| &graph.Node{ | ||
| Cum: 10, | ||
| }, | ||
| &graph.Node{ | ||
| Cum: 5, | ||
| }, | ||
| &graph.Node{ | ||
| Cum: 8, | ||
| }, | ||
| }, | ||
| output: map[float64]float64{10: 5, 20: 5, 40: 8, 60: 8, 80: 10}, | ||
| }, | ||
| } { | ||
| if percentiles := calculatePercentiles(testCase.fnodes); !reflect.DeepEqual(percentiles, testCase.output) { | ||
| t.Errorf("%v is not equal to %v", percentiles, testCase.output) | ||
|
There was a problem hiding this comment. |
||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestWebList(t *testing.T) { | ||
| if runtime.GOOS != "linux" || runtime.GOARCH != "amd64" { | ||
| t.Skip("weblist only tested on x86-64 linux") | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getPercentileString- this is not just string, this is CSS class name?