Merge pull request #9369 from google/bug/9368-standardize-rrm-notific…

…ation-ga-events Bug/9368 Standardize RRM notification GA events
google · Sep 18, 2024 · 5d53e38 · 5d53e38
2 parents 9f69bd3 + 1f38c73
commit 5d53e38
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.../modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js b/.../modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
@@ -107,7 +107,7 @@ function RRMSetupSuccessSubtleNotification() {
 	const handleDismiss = () => {
 		if ( targetOnboardingStates.includes( publicationOnboardingState ) ) {
 			trackEvent(
-				`${ viewContext }_rrm-setup-success-notification`,
+				`${ viewContext }_setup-success-notification-rrm`,
 				'dismiss_notification',
 				publicationOnboardingState
 			);
@@ -130,7 +130,7 @@ function RRMSetupSuccessSubtleNotification() {
 
 		if ( targetOnboardingStates.includes( publicationOnboardingState ) ) {
 			trackEvent(
-				`${ viewContext }_rrm-setup-success-notification`,
+				`${ viewContext }_setup-success-notification-rrm`,
 				'confirm_notification',
 				publicationOnboardingState
 			);
@@ -153,7 +153,7 @@ function RRMSetupSuccessSubtleNotification() {
 			targetOnboardingStates.includes( publicationOnboardingState )
 		) {
 			trackEvent(
-				`${ viewContext }_rrm-setup-success-notification`,
+				`${ viewContext }_setup-success-notification-rrm`,
 				'view_notification',
 				publicationOnboardingState
 			);

diff --git a/...les/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js b/...les/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js
@@ -166,7 +166,7 @@ describe( 'RRMSetupSuccessSubtleNotification', () => {
 
 			expect( mockTrackEvent ).toHaveBeenNthCalledWith(
 				1,
-				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_rrm-setup-success-notification`,
+				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_setup-success-notification-rrm`,
 				'view_notification',
 				onboardingState
 			);
@@ -177,7 +177,7 @@ describe( 'RRMSetupSuccessSubtleNotification', () => {
 
 			expect( mockTrackEvent ).toHaveBeenNthCalledWith(
 				2,
-				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_rrm-setup-success-notification`,
+				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_setup-success-notification-rrm`,
 				'confirm_notification',
 				onboardingState
 			);
@@ -210,7 +210,7 @@ describe( 'RRMSetupSuccessSubtleNotification', () => {
 
 			expect( mockTrackEvent ).toHaveBeenNthCalledWith(
 				1,
-				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_rrm-setup-success-notification`,
+				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_setup-success-notification-rrm`,
 				'view_notification',
 				onboardingState
 			);
@@ -221,7 +221,7 @@ describe( 'RRMSetupSuccessSubtleNotification', () => {
 
 			expect( mockTrackEvent ).toHaveBeenNthCalledWith(
 				2,
-				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_rrm-setup-success-notification`,
+				`${ VIEW_CONTEXT_MAIN_DASHBOARD }_setup-success-notification-rrm`,
 				'dismiss_notification',
 				onboardingState
 			);