Fix glitches / errors when changing the audience selection in mobile viewports. #9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techanvil
commented
Aug 23, 2024
| @@ -186,7 +177,6 @@ public function __construct( | |||
| ) { | |||
| parent::__construct( $context, $options, $user_options, $authentication, $assets ); | |||
| $this->custom_dimensions_data_available = new Custom_Dimensions_Data_Available( $this->transients ); | |||
| $this->audience_settings = new Audience_Settings( $this->user_options ); | |||
There was a problem hiding this comment.
This is an unrelated tidyup, this Audience_Settings instance isn't needed any more.
techanvil
force-pushed
the
bug/9168-fix-mobile-audience-selection-glitches
branch
from
57a4244
to
186faed
Compare
…ng the audience selection.
techanvil
force-pushed
the
bug/9168-fix-mobile-audience-selection-glitches
branch
from
186faed
to
e6c1662
Compare
|
Build files for 20cde47 have been deleted. |
|
Size Change: -478 B (-0.03%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
hussain-t
approved these changes
Sep 16, 2024
hussain-t
deleted the
bug/9168-fix-mobile-audience-selection-glitches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist