Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Added empty condition to solve the conflict with CartFlows and Google Site Kit. #9278

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

🐛Added empty condition to solve the conflict with CartFlows and Google Site Kit. #9278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe20986
:bug: Added empty condition to solve the conflict with CartFlows and …
sarangshahane Sep 3, 2024
1469c0b
:pencil: Updated the inline code comment
sarangshahane Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/Core/Conversion_Tracking/Conversion_Event_Providers/WooCommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ function ( $order_id ) use ( $input ) {
// order.
$order_key = $input->filter( INPUT_GET, 'key' );

// Don't output the script tag if the order key is invalid.
if ( ! $order->key_is_valid( $order_key ) ) {
// Don't output the script tag if the order key is invalid or empty.
if ( empty( $order_key ) || ! $order->key_is_valid( $order_key ) ) {
return;
}

Expand Down