Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/8179 audience settings unhappy setup path #9327

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Enhance/8179 audience settings unhappy setup path #9327

wants to merge 3 commits into from
+262 −18

Conversation

kuasha420
Copy link
Contributor

@kuasha420 kuasha420 commented Sep 11, 2024 •
edited by benbowler
Loading

Summary

Addresses issue:

Relevant technical choices

Note from @benbowler, I took this over as of 13 September 2024. Updating the flow and adding thorough tests.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

kuasha420 and others added 3 commits September 11, 2024 16:31
@kuasha420
Add error handling on Audience Settings Setup CTA.
33f47a1
@kuasha420
Merge POC oauth error redirect url.
63530de 
Squashed commit of the following:

commit 3919b7e
Author: Tom Rees-Herdman <[email protected]>
Date:   Wed Sep 4 13:24:57 2024 +0100

    Tidy up debug comments.

commit ab1ce2d
Author: Tom Rees-Herdman <[email protected]>
Date:   Wed Sep 4 13:20:15 2024 +0100

    Add PoC support for an error redirect URL for OAuth errors.

    This allows the default behaviour which is to redirect to the dashboard
    or splash screen to be overridden, e.g. to allow the user to return to
    the Settings screen on an OAuth error.
@benbowler
Complete audience settings unhappy path.
10394a1
@benbowler benbowler marked this pull request as ready for review September 16, 2024 13:43
@github-actions GitHub Actions
Copy link

Build files for 10394a1 are ready:

@techanvil techanvil mentioned this pull request Sep 19, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuasha420 @benbowler