Show 'Display visitor groups in dashboard' toggle even if GA is disco… #9349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 286bb58 have been deleted. |
|
Size Change: +2.3 kB (+0.13%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
hussain-t
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Great work, @ankitrox! LGTM 👍
Just a heads-up, I made a minor adjustment to rearrange the import and updated the QAB to ensure that Audience Segmentation is enabled to configure the audiences. Without this, the configured audiences would return as null.
…ogle/site-kit-wp into enhancement/9264-visitor-group-toggle.
|
Thank you @hussain-t I've addressed the issues in E2E and there are no relevant errors. I can see that JS tests, VRT are failing in pipeline, but getting passed in local, so moving this to CR. |
techanvil
reviewed
Sep 19, 2024
Comment on lines
+47
to
+48
| const configuredAudiences = useSelect( ( select ) => | ||
| select( CORE_USER ).getConfiguredAudiences() |
There was a problem hiding this comment.
Hi @ankitrox, this change has introduced a regression as reported by @wpdarren in Slack.
We need to guard against the request to the audience-settings endpoint with a check for audienceSegmentationEnabled here:
Suggested change
| const configuredAudiences = useSelect( ( select ) => | |
| select( CORE_USER ).getConfiguredAudiences() | |
| const configuredAudiences = useSelect( | |
| ( select ) => | |
| audienceSegmentationEnabled && | |
| select( CORE_USER ).getConfiguredAudiences() |
Please can you raise a followup PR to fix it, targeting the main branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nnected.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist