Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency_support: bump bazel_rules_hdl #1230

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

lpawelcz
Copy link
Contributor

This PR includes fixes for #1031:

  • improve hermetic python handling
  • remove cpython and embedded_python_interpreter

Additionally, the bumped version of bazel_rules_hdl include work related to improving bazel place_and_route flow (hdl/bazel_rules_hdl#239) and benchmarking experience (#1226)

CC @proppy

@@ -38,8 +38,8 @@ def repo():
)

# Current as of 2023-12-05
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this date!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for pointing that out.

@ericastor ericastor self-assigned this Dec 15, 2023
@lpawelcz
Copy link
Contributor Author

lpawelcz commented Dec 18, 2023

There are some pending PRs in bazel_rules_hdl which are related to place_and_route flow and design benchmarking that should be merged in the nearest future, e.g.:

We could wait for these to get merged and then bump this PR to include all changes or merge as it is now and open another PR with next update once bazel_rules_hdl PRs are merged.

@lpawelcz lpawelcz force-pushed the pcza/bump-bazel-rules-hdl branch 2 times, most recently from e69a58d to 0ea5cf0 Compare December 21, 2023 08:06
@lpawelcz
Copy link
Contributor Author

@proppy all recent PRs with improvements to place and route rules in bazel_rules_hdl are merged. I've bumped our bazel_rules_hdl dependency to include those.

* improve hermetic python handling
* remove cpython and embedded_python_interpreter
* place_and_route rules improvements

Signed-off-by: Pawel Czarnecki <[email protected]>
@copybara-service copybara-service bot merged commit 26331b2 into google:main Dec 21, 2023
4 checks passed
@lpawelcz lpawelcz deleted the pcza/bump-bazel-rules-hdl branch December 21, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants