feat(gapic-generator): Change REGAPIC pagination algorithm to the standard algorithm for non-compute clients #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
force-pushed
the
pr/regapic-pagination
branch
3 times, most recently
from
f7ca806 to
c394de3
Compare
dazuma
force-pushed
the
pr/regapic-pagination
branch
from
c394de3 to
c5b8976
Compare
…ndard algorithm for non-compute clients
dazuma
force-pushed
the
pr/regapic-pagination
branch
from
c5b8976 to
87d7ed8
Compare
| return "::Gapic::Rest::PagedEnumerable<#{pagination.paged_element_doc_type}>" if paged? | ||
| if paged? | ||
| elem_type = compute_pagination&.paged_element_doc_type | ||
| elem_type ||= (lro? ? "::Gapic::Operation" : @main_method.paged_response_type) |
There was a problem hiding this comment.
This will always return false
There was a problem hiding this comment.
Are you sure? It's not possible to be both paged? and lro?? The logic in MethodPresenter#lro? seems to account for the case of both.
There was a problem hiding this comment.
you're checking for lro? 2 lines up and bailing out if it's true though
There was a problem hiding this comment.
Oh 🤦🏻♂️ you're right. Okay I don't understand fully the cases here, but I guess we'll retain the current logic.
viacheslav-rostovtsev
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See internal issue b/382502247. This updates the pagination detection algorithm for REST/REGAPIC clients so it complies with AIP-158. It does not affect compute, which should remain on the custom algorithm.
This will cause breaking changes in 70-ish GAPICs, where pagination behavior for some REST RPC methods will change. Thus, this should be merged and applied with care.