Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: migrate gax to Node 18 #1699

Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 59 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
5817b0c
chore!: migrate gax to Node 18
sofisl Feb 5, 2025
0645b00
cleanup
sofisl Feb 5, 2025
25cec21
chore: upgrade to node 18
sofisl Feb 5, 2025
e4bb773
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 5, 2025
bb2ffee
migrate to node 18
sofisl Feb 5, 2025
5c0f1e2
Merge branch 'migrateToNode18' of github.com:googleapis/gax-nodejs in…
sofisl Feb 5, 2025
d6cf4a2
downgrade dep
sofisl Feb 5, 2025
5c3bb9e
update package.json
sofisl Feb 5, 2025
41e6f43
downgrade dep
sofisl Feb 5, 2025
77a09d9
chore: update to node-feth v3 and fix typings issues
sofisl Feb 5, 2025
f0f5b2f
downgrade execa
sofisl Feb 5, 2025
8557dda
try to make node-fetch v3 work
sofisl Feb 5, 2025
eb21931
update node version
sofisl Feb 5, 2025
4417e51
update regapic
sofisl Feb 5, 2025
fafdf8d
chore: update regapic imports
sofisl Feb 5, 2025
2998c86
reconfigure mocking
sofisl Feb 5, 2025
f513fc5
chore: use node-fetch v3
sofisl Feb 6, 2025
0146332
Update CODEOWNERS
sofisl Feb 6, 2025
aee4167
Update release-trigger.yml
sofisl Feb 6, 2025
1f59b35
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 6, 2025
f9f4fba
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 6, 2025
f97d5b1
Merge branch 'migrateToNode18' of https://github.com/googleapis/gax-n…
gcf-owl-bot[bot] Feb 6, 2025
2df3690
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 6, 2025
4962d0d
Merge branch 'migrateToNode18' of https://github.com/googleapis/gax-n…
gcf-owl-bot[bot] Feb 6, 2025
c61ef4f
attempt to get browser tests working
sofisl Feb 6, 2025
13fce6a
Merge branch 'migrateToNode18' of github.com:googleapis/gax-nodejs in…
sofisl Feb 6, 2025
9bba5b9
add json file to tsconfig
sofisl Feb 6, 2025
383f957
retry
sofisl Feb 6, 2025
49b3074
retry
sofisl Feb 7, 2025
b1506ff
retry
sofisl Feb 7, 2025
2124ee7
retry
sofisl Feb 7, 2025
8b0fb9b
more ts changes
sofisl Feb 7, 2025
08808cb
retry
sofisl Feb 7, 2025
03edc2f
retry
sofisl Feb 7, 2025
490ff7a
retry loading node fetch
sofisl Feb 8, 2025
f53600c
reattempt to lalow dynamic import
sofisl Feb 8, 2025
7c74e6c
revert node-fetch
sofisl Feb 8, 2025
b458afe
readd json files
sofisl Feb 8, 2025
fe0010a
readd json files
sofisl Feb 8, 2025
a4ff5d8
downgrade types/node
sofisl Feb 8, 2025
d769766
retry
sofisl Feb 8, 2025
4dae5f2
retry browser test
sofisl Feb 12, 2025
088b895
PR cleanup;
sofisl Feb 12, 2025
dc68ddc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 12, 2025
6a17aa6
Update .OwlBot.lock.yaml
sofisl Feb 12, 2025
fb21aad
Update .OwlBot.lock.yaml
sofisl Feb 12, 2025
ec75dad
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 12, 2025
16e0200
revert change to tsconfig
sofisl Feb 12, 2025
3fa46e5
Merge branch 'migrateToNode18' of github.com:googleapis/gax-nodejs in…
sofisl Feb 12, 2025
5f44ad8
remove node 12 configs
sofisl Feb 12, 2025
2286d63
fix: upgrade webpack to v5 to match the new typescript version
sofisl Feb 13, 2025
11d5c64
run lint
sofisl Feb 13, 2025
ebb485f
attempt to fix linting problem
sofisl Feb 13, 2025
c2eacde
remove floating promises TS error for tests
sofisl Feb 13, 2025
93cdeaf
add @ sign to disable linting
sofisl Feb 13, 2025
fd809ce
chore: migrate tools to node 18 as well
sofisl Feb 13, 2025
3bd82aa
downgrade walkup
sofisl Feb 13, 2025
75deabf
run lint
sofisl Feb 13, 2025
99825f5
fix lint
sofisl Feb 13, 2025
2d48dbb
attempt to upgrade node-fetch to v3
sofisl Feb 15, 2025
b76905c
run lint
sofisl Feb 15, 2025
0696ae5
readd abort controller
sofisl Feb 15, 2025
45fc98f
readd abort controller in test
sofisl Feb 15, 2025
d3aa828
run lint
sofisl Feb 15, 2025
b6f2d83
run lint
sofisl Feb 15, 2025
6bdcbd0
fix tests
sofisl Feb 15, 2025
f047cf8
fix tests
sofisl Feb 15, 2025
4ea8b2b
run lint
sofisl Feb 15, 2025
c40b9b9
Merge branch 'main' into migrateToNode18
d-goog Feb 15, 2025
c90e574
upgradependencies
sofisl Feb 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ branchProtectionRules:
- docs
- lint-gax
- lint-tools
- test-gax (14)
- test-gax (18)
- test-gax (16)
- test-tools (14)
- test-tools (18)
- test-tools (16)
- cla/google
- windows-gax
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -30,7 +30,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 16]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -51,7 +51,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -72,7 +72,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -95,7 +95,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm test
env:
Expand All @@ -106,7 +106,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd tools; npm install
- run: cd tools; npm test
env:
Expand All @@ -117,7 +117,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd logging-utils; npm install
- run: cd logging-utils; npm test
env:
Expand All @@ -128,7 +128,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm run lint
lint-tools:
Expand All @@ -137,7 +137,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd tools; npm install
- run: cd tools; npm run lint
lint-logging-utils:
Expand All @@ -146,7 +146,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd logging-utils; npm install
- run: cd logging-utils; npm run lint
docs:
Expand All @@ -155,7 +155,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: cd gax; npm install
- run: cd gax; npm run docs
- uses: JustinBeckwith/linkinator-action@v1
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node14/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node14/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/system-test.cfg

This file was deleted.

Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node14/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/system-test.cfg

This file was deleted.

Empty file.
2 changes: 1 addition & 1 deletion .kokoro/release/docs.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/release/publish.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading